-
Notifications
You must be signed in to change notification settings - Fork 670
Gitlab.from_config doesn't allow string ssl_verify #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've got a hacky workaround in the meantime:
|
Closed
I can probably make a pull request to handle this within the next few weeks. Shouldn't be hard. I'm thinking leave line 66 as-is, but on exception it should instead try to |
mdhausman
pushed a commit
to wayfair-archive/python-gitlab
that referenced
this issue
Jul 24, 2017
mdhausman
pushed a commit
to wayfair-archive/python-gitlab
that referenced
this issue
Jul 24, 2017
- Also updates documentation - See issues python-gitlab#204 and python-gitlab#270
mdhausman
pushed a commit
to wayfair-archive/python-gitlab
that referenced
this issue
Jul 31, 2017
- Also updates documentation - See issues python-gitlab#204 and python-gitlab#270
mdhausman
pushed a commit
to wayfair-archive/python-gitlab
that referenced
this issue
Aug 1, 2017
- Also updates documentation - See issues python-gitlab#204 and python-gitlab#270
mdhausman
pushed a commit
to wayfair-archive/python-gitlab
that referenced
this issue
Aug 1, 2017
- Also updates documentation - See issues python-gitlab#204 and python-gitlab#270
mdhausman
pushed a commit
to wayfair-archive/python-gitlab
that referenced
this issue
Aug 3, 2017
- Also updates documentation - See issues python-gitlab#204 and python-gitlab#270
mdhausman
pushed a commit
to wayfair-archive/python-gitlab
that referenced
this issue
Aug 3, 2017
- Also updates documentation - See issues python-gitlab#204 and python-gitlab#270
mdhausman
pushed a commit
to wayfair-archive/python-gitlab
that referenced
this issue
Aug 4, 2017
- Also updates documentation - See issues python-gitlab#204 and python-gitlab#270
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
For many users who are working with self-signed certs, ssl verification can be troublesome. I found that while I could use python-gitlab with our internal certs, I can't do it from a configuration file.
For instance, this works:
But when I tried to set up a config file like
And call it with
gitlab_dao = gitlab.Gitlab.from_config('somewhere', ['my-config.cfg'])
, it would break ongitlab_dao.auth()
.Some debugging led me to the reason: GitlabConfigParser line 66:
self.ssl_verify = self._config.getboolean(self.gitlab_id, 'ssl_verify')
Because it's only looking for a boolean, it throws an exception here and sets ssl_verify to
True
. This kills the internal cert.The text was updated successfully, but these errors were encountered: