fix(objects): Added approval rule name to data #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Totally missed that. Could you please format your code with black and start the commit message in present tense and small letters? Thanks 👍 |
Updating approvers new api needs a POST call. Also It needs a name of the new rule, defaulting this to 'name'.
f7130a6 to
70c0cfb
Compare
|
@max-wittig All fixed! |
|
@charlesfayal Sorry for the delay, but I think there is a small copy paste error |
max-wittig
reviewed
Feb 24, 2020
| @@ -2707,12 +2707,13 @@ def set_approvers( | |||
| self._parent.get_id(), | |||
| ) | |||
| data = { | |||
| "approvals_required": approvals_required, | |||
| "name": "name", | |||
| "self.assertEqual(expected, actual, 'message')pprovals_required": approvals_required, | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new gitlab api needs a name for the approval rules, added a default one to maintain the python-gitlab api.
The prior pull request wasn't ready for merge, needed this fix.