Thanks a lot for this @bgamari! It'll just need a slight git commit --amend to something like feat(users): add approve and reject methods to keep the linter happy as we use it to generate the changelog.

If you can, would you be able to add tests for this in https://github.com/python-gitlab/python-gitlab/blob/main/tests/unit/objects/test_users.py?

Codecov Report

Merging #2061 (f57139d) into main (8f8611a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2061      +/-   ##
==========================================
+ Coverage   94.69%   94.71%   +0.01%     
==========================================
  Files          78       78              
  Lines        5056     5070      +14     
==========================================
+ Hits         4788     4802      +14     
  Misses        268      268              

Flags with carried forward coverage won't be shown. Click here to find out more.

I have amended the commit message as suggested.

Unfortunately, it's not clear how to test this robustly given that the GitLab instance the tests are being run against must be configured to have new account approvals enabled. However, I am using this patch locally in managing spam account creation on https://gitlab.haskell.org/

I have amended the commit message as suggested.

Unfortunately, it's not clear how to test this robustly given that the GitLab instance the tests are being run against must be configured to have new account approvals enabled. However, I am using this patch locally in managing spam account creation on https://gitlab.haskell.org/

Thanks for the quick response @bgamari!

We run integration tests against a gitlab container, but for unit tests, we just mock the responses (see file linked above). We usually just use the example responses from the API docs for the mocked response. I guess we should document this in our contributing guide a bit more, thanks for the feedback! 😁

In this case, this would just be "Examples responses" in https://docs.gitlab.com/ee/api/users.html#approve-user - we only really need to test the success case.

It's not really the best example, but you could check https://github.com/python-gitlab/python-gitlab/blob/main/tests/unit/objects/test_users.py#L63-L72 to see how the fixtures are used because it's so similar (though ideally we'd have an individual response as a fixture). Let me know if you're happy to work on that, otherwise we can merge and do this after. Thanks again :)

Thanks for the feedback, @nejch. I'll add a few unit tests.

@bgamari thanks again for this, I rebased your branch and squashed the commit co-authored by John to make pre-commit happy. @JohnVillalovos LGTM any other concerns on your side?

@bgamari thanks again for this, I rebased your branch and squashed the commit co-authored by John to make pre-commit happy. @JohnVillalovos LGTM any other concerns on your side?

@nejch LGTM. I'm good to merge if you are.