-
Notifications
You must be signed in to change notification settings - Fork 671
fix: support array types for most resources #2196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
44970c9
to
e740cfa
Compare
Codecov Report
@@ Coverage Diff @@
## main #2196 +/- ##
==========================================
+ Coverage 95.53% 95.55% +0.01%
==========================================
Files 81 81
Lines 5309 5331 +22
==========================================
+ Hits 5072 5094 +22
Misses 237 237
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! That looks like it took a lot of time to go through all the docs!! Thanks.
Left comments on two things I saw.
e740cfa
to
6716897
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nejch
Closes #780.
I skipped
array of hashes
and I didn't touch some endpoints like merge requests that I think need another look at this topic (merge requests in particular). It's already a chunky PR, so I split it into fix/test/docs commits.