Skip to content

fix: support array types for most resources #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Conversation

nejch
Copy link
Member

@nejch nejch commented Jul 28, 2022

Closes #780.

I skipped array of hashes and I didn't touch some endpoints like merge requests that I think need another look at this topic (merge requests in particular). It's already a chunky PR, so I split it into fix/test/docs commits.

@nejch nejch marked this pull request as ready for review July 28, 2022 11:34
@nejch nejch force-pushed the fix/array-attributes branch from 44970c9 to e740cfa Compare July 28, 2022 11:34
@codecov-commenter
Copy link

Codecov Report

Merging #2196 (44970c9) into main (510ec30) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 44970c9 differs from pull request most recent head e740cfa. Consider uploading reports for the commit e740cfa to get more accurate results

@@            Coverage Diff             @@
##             main    #2196      +/-   ##
==========================================
+ Coverage   95.53%   95.55%   +0.01%     
==========================================
  Files          81       81              
  Lines        5309     5331      +22     
==========================================
+ Hits         5072     5094      +22     
  Misses        237      237              
Flag Coverage Δ
api_func_v4 81.56% <100.00%> (+0.07%) ⬆️
cli_func_v4 83.11% <100.00%> (+0.29%) ⬆️
unit 87.33% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/projects.py 100.00% <ø> (ø)
gitlab/v4/objects/broadcast_messages.py 100.00% <100.00%> (ø)
gitlab/v4/objects/deploy_tokens.py 100.00% <100.00%> (ø)
gitlab/v4/objects/environments.py 100.00% <100.00%> (ø)
gitlab/v4/objects/group_access_tokens.py 100.00% <100.00%> (ø)
gitlab/v4/objects/invitations.py 100.00% <100.00%> (ø)
gitlab/v4/objects/jobs.py 78.26% <100.00%> (+0.64%) ⬆️
gitlab/v4/objects/members.py 94.82% <100.00%> (ø)
gitlab/v4/objects/personal_access_tokens.py 100.00% <100.00%> (ø)
gitlab/v4/objects/project_access_tokens.py 100.00% <100.00%> (ø)
... and 3 more

@nejch nejch requested a review from JohnVillalovos July 28, 2022 11:36
Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! That looks like it took a lot of time to go through all the docs!! Thanks.

Left comments on two things I saw.

@nejch nejch force-pushed the fix/array-attributes branch from e740cfa to 6716897 Compare July 28, 2022 14:28
@nejch nejch requested a review from JohnVillalovos July 28, 2022 14:30
Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nejch

@JohnVillalovos JohnVillalovos enabled auto-merge (rebase) July 28, 2022 14:33
@JohnVillalovos JohnVillalovos merged commit 4a6f8d6 into main Jul 28, 2022
@JohnVillalovos JohnVillalovos deleted the fix/array-attributes branch July 28, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create impersonation token from CLI
3 participants