Skip to content

add group members all #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

add group members all #599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f3c35d
add group members all
hans-d Sep 29, 2018
26c9f9a
fix pep8
hans-d Sep 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions gitlab/v4/objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,16 @@ class GroupMemberManager(CRUDMixin, RESTManager):
_update_attrs = (('access_level', ), ('expires_at', ))


class GroupMemberAll(RESTObject):
pass


class GroupMemberAllManager(ListMixin, RESTManager):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand your goal here, but I think it would make more sense to add an all() method to the GroupMemberManager class. The RunnerManager class has the same logic. From a REST point of view all is an action applied to the resource at path /groups/:id:/members (GroupMember).

Does that make sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, hadn't seen that variation yet. Will try to change it like that soonish

_path = '/groups/%(group_id)s/members/all'
_obj_cls = GroupMemberAll
_from_parent_attrs = {'group_id': 'id'}


class GroupMergeRequest(RESTObject):
pass

Expand Down Expand Up @@ -850,6 +860,7 @@ class Group(SaveMixin, ObjectDeleteMixin, RESTObject):
('epics', 'GroupEpicManager'),
('issues', 'GroupIssueManager'),
('members', 'GroupMemberManager'),
('membersAll', 'GroupMemberAllManager'),
('mergerequests', 'GroupMergeRequestManager'),
('milestones', 'GroupMilestoneManager'),
('notificationsettings', 'GroupNotificationSettingsManager'),
Expand Down