Skip to content

Added missing attributes for project approvals #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2019
Merged

Added missing attributes for project approvals #934

merged 1 commit into from
Nov 13, 2019

Conversation

tymonx
Copy link

@tymonx tymonx commented Nov 12, 2019

Reference: https://docs.gitlab.com/ee/api/merge_request_approvals.html#change-configuration

Missing attributes:

  • merge_requests_author_approval
  • merge_requests_disable_committers_approval

fix: added missing attributes for project approvals
460ed63 
Reference: https://docs.gitlab.com/ee/api/merge_request_approvals.html#change-configuration

Missing attributes:
* merge_requests_author_approval
* merge_requests_disable_committers_approval
@tymonx tymonx force-pushed the fix-missing-attribute-for-project-approvals branch from 0b8c5cb to 460ed63 Compare November 12, 2019 01:27
@tymonx tymonx mentioned this pull request Nov 12, 2019
Closed
@max-wittig
Copy link
Member

Thanks for the MR!

@max-wittig max-wittig merged commit 9608886 into python-gitlab:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tymonx @max-wittig