This repository was archived by the owner on Jan 13, 2021. It is now read-only.
Convert headers to strings in HTTP20Adapter to fix #324 #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
suggested changes
Jul 5, 2017
hyper/contrib.py
Outdated
| @@ -132,7 +132,10 @@ def build_response(self, request, resp): | |||
| response = Response() | |||
|
|
|||
| response.status_code = resp.status | |||
| response.headers = CaseInsensitiveDict(resp.headers.iter_raw()) | |||
| response.headers = CaseInsensitiveDict(( | |||
| map(lambda h: h.decode("utf-8"), h) | |||
There was a problem hiding this comment.
This is a little overbroad. To match urllib3 we only want to do this on Python 3: on Python 2 these should stay as bytes.
Lukasa
suggested changes
Jul 5, 2017
hyper/contrib.py
Outdated
| from sys import version_info as pyver | ||
|
|
||
|
|
||
| conditionalToStr=lambda s: s.decode("utf-8") if pyver > 2 else lambda s: s |
There was a problem hiding this comment.
Absolutely no need to use a lambda here, let alone two: just use this function.
Lukasa
suggested changes
Jul 5, 2017
hyper/contrib.py
Outdated
| @@ -19,6 +19,7 @@ | |||
| from hyper.common.connection import HTTPConnection | |||
| from hyper.compat import urlparse, ssl | |||
| from hyper.tls import init_context | |||
| from hyper.util import to_native_string | |||
Lukasa
approved these changes
Jul 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.