Skip to content

Remove async magic patch from tests #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented Oct 1, 2024

Not required since AsyncMock available in python 3.8 and probably better to keep magic to a minimum.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (1026e89) to head (cdf7f19).
Report is 193 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1146   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          96       96           
  Lines        6119     6119           
  Branches     1514     1514           
=======================================
  Hits         5666     5666           
  Misses        354      354           
  Partials       99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdb9696 sdb9696 marked this pull request as ready for review October 1, 2024 13:39
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asyncmock changes look good, but was the functional change intentional?

@sdb9696 sdb9696 force-pushed the janitor/remove_test_magic branch from c9e24a8 to cdf7f19 Compare October 2, 2024 15:01
@sdb9696 sdb9696 requested a review from rytilahti October 2, 2024 15:09
@rytilahti rytilahti added the maintenance Project improvements and maintenance label Oct 2, 2024
@rytilahti rytilahti merged commit 8bb2cca into master Oct 2, 2024
28 checks passed
@rytilahti rytilahti deleted the janitor/remove_test_magic branch October 2, 2024 15:12
@sdb9696 sdb9696 added this to the 0.7.5 milestone Oct 8, 2024
@sdb9696 sdb9696 mentioned this pull request Oct 8, 2024
sdb9696 added a commit that referenced this pull request Oct 8, 2024
## [0.7.5](https://github.com/python-kasa/python-kasa/tree/0.7.5) (2024-10-08)

[Full Changelog](0.7.4...0.7.5)

**Release summary:**

- Fix for KP303 on Firmware 1.0.6
- Fix for `on_since` value jitter
- Various maintenance items

**Breaking changes:**

- Make iot time timezone aware [\#1147](#1147) (@sdb9696)

**Fixed bugs:**

- Use tzinfo in time constructor instead of astime for iot devices [\#1158](#1158) (@sdb9696)
- Send empty dictionary instead of null for iot queries [\#1145](#1145) (@sdb9696)
- Stabilise on\_since value for smart devices [\#1144](#1144) (@sdb9696)
- parse\_pcap\_klap: require source host [\#1137](#1137) (@rytilahti)
- parse\_pcap\_klap: use request\_uri for matching the response [\#1136](#1136) (@rytilahti)


**Project maintenance:**

- Cache zoneinfo for smart devices [\#1156](#1156) (@sdb9696)
- Correctly define SmartModule.call as an async function [\#1148](#1148) (@sdb9696)
- Remove async magic patch from tests [\#1146](#1146) (@sdb9696)
- Move feature initialization from \_\_init\_\_ to \_initialize\_features [\#1140](#1140) (@rytilahti)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Project improvements and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants