Skip to content

Make bytes warnings more useful #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tiran opened this issue Dec 15, 2017 · 0 comments
Closed

Make bytes warnings more useful #132

tiran opened this issue Dec 15, 2017 · 0 comments
Labels
ease-of-use

Comments

@tiran
Copy link
Member

tiran commented Dec 15, 2017

From #128 (comment)

It's still hard to pin point bytes issues. The warning message does not include a hint, which argument is wrong. We may want to consider to include the name of the argument with invalid type (e.g. dn) in the warning message. python-ldap must not include the actual value, because it may contain confidential information like credentials.
encukou added a commit to encukou/python-ldap that referenced this issue Dec 19, 2017
@encukou
Show argument name instead of content in LDAPBytesWarning
2a6c8ba 
Based on earlier patch by Christian Heimes
Fixes: python-ldap#132
Fixes: python-ldap#144
@encukou encukou mentioned this issue Dec 19, 2017
Merged
encukou added a commit that referenced this issue Dec 20, 2017
@encukou
Show argument name instead of content in LDAPBytesWarning
9fb9338 
Based on earlier patch by Christian Heimes
#145
Fixes: #132
Fixes: #144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ease-of-use
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@encukou @tiran