Show argument name instead of content in LDAPBytesWarning #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on earlier patch by Christian Heimes Fixes: python-ldap#132 Fixes: python-ldap#144
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 69.33% 69.36% +0.02%
==========================================
Files 49 49
Lines 4654 4641 -13
Branches 782 780 -2
==========================================
- Hits 3227 3219 -8
+ Misses 1080 1075 -5
Partials 347 347
Continue to review full report at Codecov.
|
tiran
approved these changes
Dec 19, 2017
| @@ -532,7 +522,7 @@ def delete_ext(self,dn,serverctrls=None,clientctrls=None): | |||
| form returns the message id of the initiated request, and the | |||
| result can be obtained from a subsequent call to result(). | |||
| """ | |||
| dn = self._bytesify_input(dn) | |||
| dn = self._bytesify_input('dn', dn) | |||
There was a problem hiding this comment.
_bytesify_input already contains a check. I only added the PY2 check when there were several calls to _bytesify_input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on earlier patch by Christian Heimes
Fixes: #132
Fixes: #144