Support OPT_X_TLS_PEERCERT #427
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to a bug in OpenLDAP, LDAP_OPT_X_TLS_PEERCERT leaks memory: https://bugs.openldap.org/show_bug.cgi?id=9696 |
f5d29ea to
9863bb7
Compare
encukou
reviewed
Sep 17, 2021
Tests/t_ldapobject.py
Outdated
| server_pem = f.read() | ||
| # remove text | ||
| begin = server_pem.find("-----BEGIN CERTIFICATE-----") | ||
| server_pem = server_pem[begin:-1] |
There was a problem hiding this comment.
nitpick: Is removing the final character important? In our case itdoesn't really matter, but if the file doesn't end with a newline, the exception you get here is a bit obscure.
Suggested change
| server_pem = server_pem[begin:-1] | |
| server_pem = server_pem[begin:] |
Co-authored-by: Thomas Grainger <tagrain@gmail.com> Signed-off-by: Christian Heimes <cheimes@redhat.com>
mistotebe
reviewed
Dec 13, 2021
| @@ -421,6 +428,33 @@ def test_multiple_starttls(self): | |||
| l.simple_bind_s(self.server.root_dn, self.server.root_pw) | |||
| self.assertEqual(l.whoami_s(), 'dn:' + self.server.root_dn) | |||
|
|
|||
| @requires_tls() | |||
| @unittest.skipUnless( | |||
| hasattr(ldap, "OPT_X_TLS_PEERCERT"), | |||
There was a problem hiding this comment.
Sounds like you still need to register this in Lib/ldap/constants.py to get the tests enabled?
|
Already done as part of #458 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces PR #401