-
-
Notifications
You must be signed in to change notification settings - Fork 136
Any schema type #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any schema type #73
Conversation
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 98.22% 98.24% +0.02%
==========================================
Files 54 54
Lines 1238 1253 +15
==========================================
+ Hits 1216 1231 +15
Misses 22 22
Continue to review full report at Codecov.
|
5879e18
to
5fec41f
Compare
Looks good. Should allOf/oneOf have types? https://github.com/p1c2u/openapi-core/pull/73/files#diff-431dcafe8bb0f93322e443187632f52fR198 Looking at examples this is not the case https://swagger.io/docs/specification/data-models/oneof-anyof-allof-not/. For #65 I tested using
This passed validation in openapi-core but plugging it into swagger-ui yeilds a convoluted data structure. |
That's why I didn't merge it still. I'm not 100% sure how it should work. I need to add one change to any type unmarshaling. |
5fec41f
to
552827e
Compare
552827e
to
cf53e19
Compare
This PR won't resolve #65 . It needs separate PR. |
d958fe8
to
28d4d0b
Compare
28d4d0b
to
0cbbdb0
Compare
Any schema type
Related to #36
It's a first step to support oneof