Skip to content

fix: ignore dependencies versions bump when parsing version from commit logs #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

fix: ignore dependencies versions bump when parsing version from commit logs #472

wants to merge 5 commits into from

Conversation

browniebroke
Copy link
Contributor

Fix #442

@browniebroke browniebroke marked this pull request as ready for review July 14, 2022 22:02
@browniebroke browniebroke force-pushed the fix/version-parsing-commit branch from fb57492 to 9e9a9bc Compare July 14, 2022 22:03
@browniebroke browniebroke force-pushed the fix/version-parsing-commit branch from 65c7968 to fb57492 Compare July 14, 2022 22:11
@browniebroke browniebroke mentioned this pull request Jul 14, 2022
Closed
@eifinger
Copy link
Contributor

I tested it in my repo and it works: https://github.com/eifinger/here_routing/runs/7353567801?check_suite_focus=true

@eifinger
Copy link
Contributor

@browniebroke I just had a new run with your changes and it broke.

https://github.com/eifinger/here_routing/runs/7389213534?check_suite_focus=true

Your changes did not account for a custom commit_subject:
https://github.com/eifinger/here_routing/blob/main/pyproject.toml#L84

@browniebroke
Copy link
Contributor Author

Ok, thanks for the feedback! I didn't know about this option, I guess that explain why re.search is used instead of re.match. Seems related to a recent change marged in #466 as well.

I'll see if I can take this into account 👍🏻

@eifinger eifinger mentioned this pull request Jul 21, 2022
Merged
@browniebroke
Copy link
Contributor Author

Please chek out #476 for a more up-to-date fix

@browniebroke browniebroke deleted the fix/version-parsing-commit branch July 24, 2022 09:21
@browniebroke browniebroke restored the fix/version-parsing-commit branch July 24, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflows with python-semantic-release broke on 03.05.22
2 participants
@browniebroke @eifinger