Skip to content

Logo #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Logo #188

wants to merge 1 commit into from

Conversation

tomschr
Copy link
Member

@tomschr tomschr commented Nov 10, 2019 •
edited by s-celles
Loading

This PR contains:

  • Logo (squared logo) in SVG format
  • Configuration option html_logo in docs/conf.py

Co-authored-by: scls19fr

Closes #187

@tomschr tomschr added Doc Documentation related issue Infra All about infrastructure (GitHub Action, project build etc.) labels Nov 10, 2019
@tomschr tomschr requested a review from s-celles November 10, 2019 09:41
@tomschr tomschr mentioned this pull request Nov 10, 2019
Closed
@tomschr tomschr self-assigned this Nov 10, 2019
s-celles
s-celles requested changes Nov 10, 2019
View reviewed changes
Copy link
Member

@s-celles s-celles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomschr
Could you add a note in CHANGELOG?

@tomschr
Fix python-semver#187: Create a squared logo
63d4d22 
* Mentioned in issue python-semver#177
* Add logo to documentation
* Update CHANGELOG

Co-authored-by: scls19fr
@tomschr
Copy link
Member Author

tomschr commented Nov 10, 2019

Oh yes, of course! I've added a line in commit 63d4d22

@s-celles s-celles changed the title Fix #187: Create a squared logo Logo Nov 10, 2019
@s-celles s-celles self-requested a review November 10, 2019 10:53
@s-celles
Copy link
Member

I can't understand what's wrong with that PR.

Some checks haven’t completed yet
2 expected and 1 successful checks
Travis CI - Branch Expected — Waiting for status to be reported
Required
continuous-integration/travis-ci Expected — Waiting for status to be reported
Required

I tried triggering Travis. But it doesn't help.

@tomschr
Copy link
Member Author

tomschr commented Nov 10, 2019 •
edited by s-celles
Loading

Hmn, strange. I've looked at Travis and it looks ok. There was also no incidents reported on http://status.github.com/... 🤔 💭

@s-celles
Copy link
Member

Hi @tomschr,
I've retriggered Travis this morning... but it had no effects.
I see no other solution than closing this PR and opening an other one.
Really sorry about that.

@tomschr
Copy link
Member Author

tomschr commented Nov 11, 2019 •
edited
Loading

@scls19fr Don't worry such things can happen. 😄 Had this strange behavior in the past too from time to time. I suspect the culprit is Travis.
I'm not aware that I did something wrong, the only change was the logo and the Changelog. 😉

If I should open another PR to help you, let me know. :-)

@s-celles
Copy link
Member

@tomschr Could you work on a feature/logo3 PR? With such a number it will be synchronized with our logo 😄

@tomschr tomschr mentioned this pull request Nov 11, 2019
Merged
@tomschr
Copy link
Member Author

tomschr commented Nov 11, 2019

@scls19fr Sure, no problem. I've created PR #189 and closing this

With such a number it will be synchronized with our logo 😄

Indeed. 😄

@tomschr tomschr closed this Nov 11, 2019
@tomschr tomschr deleted the feature/logo2 branch November 11, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-celles s-celles s-celles approved these changes

Assignees

@tomschr tomschr

Labels
Doc Documentation related issue Infra All about infrastructure (GitHub Action, project build etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logo for python-semver
2 participants
@tomschr @s-celles