Skip to content

Fix #187: Create a squared logo #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

tomschr
Copy link
Member

@tomschr tomschr commented Nov 11, 2019

Supersede PR #188
Contains the following changes:

Co-Authored-By: scls19fr

@tomschr tomschr added Doc Documentation related issue Infra All about infrastructure (GitHub Action, project build etc.) labels Nov 11, 2019
@tomschr tomschr requested a review from s-celles November 11, 2019 13:41
@tomschr tomschr self-assigned this Nov 11, 2019
@tomschr tomschr mentioned this pull request Nov 11, 2019
@s-celles
Copy link
Member

Squash and merge is disabled (again! 😣)

@tomschr
Copy link
Member Author

tomschr commented Nov 12, 2019

I've looked into the Settings > Webhooks page for this repo and compared it with another repo which also uses Travis. The events for this and the other repo are the same, both have the same events activated.

@ppkt
Copy link
Member

ppkt commented Nov 13, 2019

@tomschr @scls19fr I'm not sure but it looks like something has changed in Travis recently, maybe we should update our workflow? travis-ci/travis-ci#10204

@tomschr
Copy link
Member Author

tomschr commented Nov 13, 2019

@ppkt Thank you very much for the hint! 👍 I would have never found that! 😆

I've disabled now the "continuous-integration/travis-ci" item, but left the other two intact. Pushed a slight change, let's see if this is working.

* Mentioned in issue python-semver#177
* Add logo to documentation
* Update CHANGELOG

Co-Authored-By: scls19fr
@tomschr
Copy link
Member Author

tomschr commented Nov 13, 2019

Ok, seems the "Travis CI - Branch" is stalled, so I've disabled that too. Pushed another commit, this should work hopefully.

@tomschr
Copy link
Member Author

tomschr commented Nov 13, 2019

@scls19fr It worked! Would you like to have a final look and merge it? Thanks! 👍

@s-celles s-celles merged commit 18ea3f8 into python-semver:master Nov 13, 2019
@s-celles
Copy link
Member

Thanks @ppkt and @tomschr
I'd have never found that without your help @ppkt!

@s-celles
Copy link
Member

Doc is available on https://python-semver.readthedocs.io/en/latest/

opinion?

I'm a bit skeptic about blue snake on blue background

@s-celles
Copy link
Member

Maybe we should remove alpha layer and have a white background for logo (and not transparent).
An other proposition could be to change RTD background

@tomschr
Copy link
Member Author

tomschr commented Nov 13, 2019

Arghhh, I think that's a bit too heavy. 😮 Maybe we should reduce the size and---as @scls19fr suggested---add a white background.

Do you know if Sphinx has an option to customize the logo size? Otherwise I would suggest to convert the SVG logo into PNG for a specific size.

An other proposition could be to change RTD background

You mean another theme?

@tomschr tomschr deleted the feature/logo3 branch November 13, 2019 08:55
@s-celles
Copy link
Member

Changing logo size and its background is probably simpler.

I don't know what is behiavor of RTD with smarphone... just wondering if vector graphics isn't better to support several resolution.

Changing RTD theme is probably overkilled

@tomschr
Copy link
Member Author

tomschr commented Nov 13, 2019

I've opened now PR #190 for this.

@tomschr
Copy link
Member Author

tomschr commented Nov 13, 2019

I don't know what is behiavor of RTD with smarphone... just wondering if vector graphics isn't better to support several resolution.

Oh, I missed that part. Well, nowadays most modern browsers should cope with SVGs. I've tested it with Firefox 68.2.0 on Android 10 and the logo is displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc Documentation related issue Infra All about infrastructure (GitHub Action, project build etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logo for python-semver
3 participants