-
Notifications
You must be signed in to change notification settings - Fork 96
Fix #187: Create a squared logo #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Squash and merge is disabled (again! 😣) |
I've looked into the Settings > Webhooks page for this repo and compared it with another repo which also uses Travis. The events for this and the other repo are the same, both have the same events activated. |
@tomschr @scls19fr I'm not sure but it looks like something has changed in Travis recently, maybe we should update our workflow? travis-ci/travis-ci#10204 |
3a5302a
to
8f1ba41
Compare
@ppkt Thank you very much for the hint! 👍 I would have never found that! 😆 I've disabled now the "continuous-integration/travis-ci" item, but left the other two intact. Pushed a slight change, let's see if this is working. |
* Mentioned in issue python-semver#177 * Add logo to documentation * Update CHANGELOG Co-Authored-By: scls19fr
8f1ba41
to
843c036
Compare
Ok, seems the "Travis CI - Branch" is stalled, so I've disabled that too. Pushed another commit, this should work hopefully. |
@scls19fr It worked! Would you like to have a final look and merge it? Thanks! 👍 |
Doc is available on https://python-semver.readthedocs.io/en/latest/ opinion? I'm a bit skeptic about blue snake on blue background |
Maybe we should remove alpha layer and have a white background for logo (and not transparent). |
Arghhh, I think that's a bit too heavy. 😮 Maybe we should reduce the size and---as @scls19fr suggested---add a white background. Do you know if Sphinx has an option to customize the logo size? Otherwise I would suggest to convert the SVG logo into PNG for a specific size.
You mean another theme? |
Changing logo size and its background is probably simpler. I don't know what is behiavor of RTD with smarphone... just wondering if vector graphics isn't better to support several resolution. Changing RTD theme is probably overkilled |
I've opened now PR #190 for this. |
Oh, I missed that part. Well, nowadays most modern browsers should cope with SVGs. I've tested it with Firefox 68.2.0 on Android 10 and the logo is displayed. |
Supersede PR #188
Contains the following changes:
Co-Authored-By: scls19fr