Skip to content

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Aug 5, 2019

Attempt to incorporate API 4.4 changes.

Stuff I'm not sure I handled it correctly:

  • de_json methods (Chat and ChatPermission)
  • Deprecation warning for all_members_are_administrators in Chat
  • new parameter sytax for restrict_chat_members in Bot
  • Does something need to be changed for the new webhooks?
  • Preparation for API 4.5, which brings nested MessageEntities: I adjusted Message._parse_html and Message._parse_markdown to allow for this. However, this only allows something like _bold *within* italic_ and not *bold _overlapping* italic_. The announcement is not every clear, if that is also allowed …

Did I miss anything?

@Nukesor
Copy link

Nukesor commented Aug 5, 2019

FYI: The 4.2 and 4.3 Changes are still not merged: #1418

@Bibo-Joshi Bibo-Joshi marked this pull request as ready for review August 8, 2019 16:35
@Nukesor
Copy link

Nukesor commented Aug 9, 2019

Pls remove the WIP: from the title , if it's really ready for review :D.
Otherwise this might be overlooked.

@Bibo-Joshi Bibo-Joshi changed the title WIP: Api 4.4 changes API 4.4 changes Aug 9, 2019
@Bibo-Joshi
Copy link
Member Author

Ah, overlooked that one. Thanks for the heads up :)

@Poolitzer Poolitzer mentioned this pull request Aug 29, 2019
Copy link
Member

@Eldinnie Eldinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes

@Bibo-Joshi Bibo-Joshi mentioned this pull request Sep 6, 2019
10 tasks
@Bibo-Joshi Bibo-Joshi added the ⚙️ bot-api affected functionality: bot-api label Sep 6, 2019
@tsnoam tsnoam requested a review from Eldinnie September 6, 2019 18:52
@tsnoam tsnoam merged commit 965ad17 into python-telegram-bot:master Sep 6, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚙️ bot-api affected functionality: bot-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants