Skip to content

Use temporary directories in test_persistence #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 4, 2020
Merged

Use temporary directories in test_persistence #1808

merged 5 commits into from
Mar 4, 2020

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Mar 4, 2020 •
edited
Loading

Closes #1765
Uses pytest s tmp_path

@Bibo-Joshi Bibo-Joshi added the ⚙️ tests affected functionality: tests label Mar 4, 2020
@Bibo-Joshi Bibo-Joshi requested a review from tsnoam March 4, 2020 07:11
@Bibo-Joshi
Copy link
Member Author

Fails on ubuntu. Need to investigate.

@Bibo-Joshi Bibo-Joshi removed the request for review from tsnoam March 4, 2020 07:19
@Bibo-Joshi Bibo-Joshi changed the title Use TemporaryDirectory in test_persistence Use temporary directories in test_persistence Mar 4, 2020
@Bibo-Joshi
Copy link
Member Author

Codecov complains about JobQueue and utils.requests. dunno, why, I'll just ignore it …

@Bibo-Joshi Bibo-Joshi requested a review from tsnoam March 4, 2020 21:46
@tsnoam tsnoam merged commit f7ec7a7 into master Mar 4, 2020
@tsnoam tsnoam deleted the fix-1765 branch March 4, 2020 21:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsnoam tsnoam tsnoam approved these changes

Assignees
No one assigned
Labels
⚙️ tests affected functionality: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use tempfile module in tests
2 participants
@Bibo-Joshi @tsnoam