You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Bibo-Joshi regarding your comment about test_set_game_score test I have prepared a draft PR with a possible workaround for this issue. PTAL artemrys@3734b01 It works for me locally.
Does it worth to create a separate bug for this issue and start discussing it there?
The failing tests are a more general issue, see also #1759. So, yes, please go ahead and pr, so we can see, if the reordering also works in the CI. Please make sure to comment, why the reorder should help.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1823
Also added a test case that makes sure that the last update & context are the same as the ones in the timeout handler.