Skip to content

Make basepersistence methods abstractmethod #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 12, 2021
Merged

Make basepersistence methods abstractmethod #2624

merged 5 commits into from
Aug 12, 2021

Conversation

starry-shivam
Copy link
Member

@starry-shivam starry-shivam commented Aug 10, 2021 •
edited
Loading

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests

Closes #2231

@starry-shivam
Make basepersistence methods abstractmethod
ae55b6b 
Signed-off-by: starry69 <starry369126@outlook.com>
@starry-shivam starry-shivam added the 🛠 breaking change type: breaking label Aug 10, 2021
@harshil21 harshil21 mentioned this pull request Aug 10, 2021
Closed
@starry-shivam
set store_callback_data to True by default
7914561 
Signed-off-by: starry69 <starry369126@outlook.com>
Bibo-Joshi
Bibo-Joshi reviewed Aug 10, 2021
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question: Is it worth adding .. versionchanged:: directives stating that the methods are abstract since v14?

@Bibo-Joshi Bibo-Joshi mentioned this pull request Aug 10, 2021
Closed
22 tasks
@starry-shivam
Copy link
Member Author

Just one question: Is it worth adding .. versionchanged:: directives stating that the methods are abstract since v14?

I think yes

@Poolitzer
Copy link
Member

Poolitzer commented Aug 11, 2021 •
edited
Loading

Isnt this supposed to merge into the V14 branch?

@Bibo-Joshi Bibo-Joshi changed the base branch from master to v14 August 11, 2021 10:03
@starry-shivam
added versionchanged directives
1d64bfc 
Signed-off-by: starry69 <starry369126@outlook.com>
starry-shivam and others added 2 commits August 12, 2021 10:05
@starry-shivam
Specify changes in versionchanged directive
7e556e7 
Signed-off-by: starry69 <starry369126@outlook.com>
@Bibo-Joshi
Minor nitpicking
778bafe
@Bibo-Joshi Bibo-Joshi merged commit be00397 into v14 Aug 12, 2021
@Bibo-Joshi Bibo-Joshi deleted the bp-abc branch August 12, 2021 06:58
@Bibo-Joshi Bibo-Joshi mentioned this pull request Aug 12, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi left review comments

Assignees
No one assigned
Labels
🛠 breaking change type: breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make BP.flush an abstract method
3 participants
@starry-shivam @Poolitzer @Bibo-Joshi