Skip to content

Conversation

rahiel
Copy link
Contributor

@rahiel rahiel commented Apr 28, 2016

This should solve #259 while keeping backward compatibility for users who don't like to change their existing code. This also fixes #255

@tsnoam
Copy link
Member

tsnoam commented Apr 28, 2016

@rahiel imo, this should issue deprecation warning at first and at a later release remove the backward compatibility

@rahiel rahiel changed the title add snake_case aliases for CamelCase methods rename methods to snake_case Apr 28, 2016
@rahiel
Copy link
Contributor Author

rahiel commented Apr 28, 2016

@rahiel imo, this should issue deprecation warning at first and at a later release remove the backward compatibility

Done! I might have missed some internal invocations the old methods.

Did I miss any other methods?

@rahiel rahiel added this to the 5.0 milestone Apr 28, 2016
@jh0ker
Copy link
Member

jh0ker commented Apr 28, 2016

Updating examples should be done on release of this, yes?

@rahiel
Copy link
Contributor Author

rahiel commented Apr 28, 2016

Updating examples should be done on release of this, yes?

Yes, I think we should quickly make a new release with the new interface so new users don't have to adapt later.

@tsnoam
Copy link
Member

tsnoam commented Apr 28, 2016

@rahiel I think it must come out together with the fixes in my PR from yesterday. I dearly hope to have the time to fix the merge tonight.

@rahiel rahiel added the 📋 pending-review work status: pending-review label Apr 30, 2016
@leandrotoledo
Copy link
Member

Reloading PyPy tests.

@leandrotoledo
Copy link
Member

Should we get this merged?

@jh0ker
Copy link
Member

jh0ker commented May 14, 2016

@leandrotoledo LGTM

@leandrotoledo leandrotoledo merged commit 56b1d4f into master May 14, 2016
@leandrotoledo leandrotoledo deleted the snakes branch May 14, 2016 13:56
@leandrotoledo leandrotoledo modified the milestones: 4.1, 5.0 May 15, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 enhancement pr description: enhancement 📋 pending-review work status: pending-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PEP8 issue: Methods should be snake case
5 participants