-
Notifications
You must be signed in to change notification settings - Fork 5.8k
rename methods to snake_case #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rahiel imo, this should issue deprecation warning at first and at a later release remove the backward compatibility |
Done! I might have missed some internal invocations the old methods. Did I miss any other methods? |
Updating examples should be done on release of this, yes? |
Yes, I think we should quickly make a new release with the new interface so new users don't have to adapt later. |
@rahiel I think it must come out together with the fixes in my PR from yesterday. I dearly hope to have the time to fix the merge tonight. |
Reloading PyPy tests. |
Should we get this merged? |
@leandrotoledo LGTM |
This should solve #259 while keeping backward compatibility for users who don't like to change their existing code. This also fixes #255