-
Notifications
You must be signed in to change notification settings - Fork 5.8k
API 9.2 SuggestedPost[Info,Approved,ApprovalFailed]
#4931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-paid-refunded Conflicts: changes/unreleased/4911.kiF45Y4cfPGMq5cuLpa5da.toml docs/source/telegram.at-tree.rst src/telegram/__init__.py src/telegram/_message.py src/telegram/_suggestedpost.py src/telegram/constants.py tests/test_suggestedpost.py
20 tasks
Bibo-Joshi
reviewed
Sep 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, just one comment :)
src/telegram/_suggestedpost.py
Outdated
): | ||
super().__init__(api_kwargs=api_kwargs) | ||
# Required | ||
self.state: str = state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we convert this to SuggestedPostInfoState? We do something like that for all the *Type
enums
Bibo-Joshi
approved these changes
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check-list for PRs
.. versionadded:: NEXT.VERSION
,.. versionchanged:: NEXT.VERSION
,.. deprecated:: NEXT.VERSION
or ``.. versionremoved:: NEXT.VERSION` to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)__all__
sIf the PR contains API changes (otherwise, you can ignore this passage)...
New Classes
self._id_attrs
and corresponding documentation__init__
acceptsapi_kwargs
as keyword-onlyAdded New Shortcutstelegram.Chat
&telegram.User
for all methods that acceptchat/user_id
telegram.Message
for all methods that acceptchat_id
andmessage_id
telegram.Message
shortcuts: Addedquote
argument if methods acceptreply_to_message_id
telegram.CallbackQuery
for all methods that accept eitherchat_id
andmessage_id
orinline_message_id
If Relevant
telegram.constants
and shortcuts to them as class variablestelegram.Message.effective_attachment
telegram.ext.ConversationHandler
API 9.2 Items:
sorry for the unrelated commits... i again based this off of #4921 while that one gets reviewed.
relevant commit to this PR start from Add classes SuggestedPost[Info,Approved,ApprovalFailed] and onwards