Skip to content

Conversation

aelkheir
Copy link
Member

@aelkheir aelkheir commented Sep 4, 2025

Check-list for PRs

  • Added .. versionadded:: NEXT.VERSION, .. versionchanged:: NEXT.VERSION, .. deprecated:: NEXT.VERSION or ``.. versionremoved:: NEXT.VERSION` to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added new classes & modules to the docs and all suitable __all__ s
  • Checked the Stability Policy in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)
...

  • New Classes

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts api_kwargs as keyword-only
  • Added New Shortcuts

    • In telegram.Chat & telegram.User for all methods that accept chat/user_id
    • In telegram.Message for all methods that accept chat_id and message_id
    • For new telegram.Message shortcuts: Added quote argument if methods accept reply_to_message_id
    • In telegram.CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If Relevant

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Linked new and existing constants in docstrings instead of hard-coded numbers and strings
    • Added new message types to telegram.Message.effective_attachment
    • Added new handlers for new update types
    • Added new filters for new message (sub)types

API 9.2 Items:

  • Added the class SuggestedPostInfo and the field suggested_post_info to the class Message, describing a suggested post.
  • Added the class SuggestedPostApproved and the field suggested_post_approved to the class Message, describing a service message about the approval of a suggested post.
  • Added the class SuggestedPostApprovalFailed and the field suggested_post_approval_failed to the class Message, describing a service message about the failed approval of a suggested post.

sorry for the unrelated commits... i again based this off of #4921 while that one gets reviewed.
relevant commit to this PR start from Add classes SuggestedPost[Info,Approved,ApprovalFailed] and onwards

…-paid-refunded

 Conflicts:
	changes/unreleased/4911.kiF45Y4cfPGMq5cuLpa5da.toml
	docs/source/telegram.at-tree.rst
	src/telegram/__init__.py
	src/telegram/_message.py
	src/telegram/_suggestedpost.py
	src/telegram/constants.py
	tests/test_suggestedpost.py
@Bibo-Joshi Bibo-Joshi mentioned this pull request Aug 28, 2025
20 tasks
@aelkheir aelkheir marked this pull request as ready for review September 6, 2025 23:07
@aelkheir aelkheir added the 📋 pending-review work status: pending-review label Sep 6, 2025
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, just one comment :)

):
super().__init__(api_kwargs=api_kwargs)
# Required
self.state: str = state
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we convert this to SuggestedPostInfoState? We do something like that for all the *Type enums

@Bibo-Joshi Bibo-Joshi merged commit de80172 into api-9.2-central Sep 7, 2025
6 of 27 checks passed
@Bibo-Joshi Bibo-Joshi deleted the info-approved-failed branch September 7, 2025 20:02
@aelkheir aelkheir removed the 📋 pending-review work status: pending-review label Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants