Skip to content

Removed unused imports #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 25, 2022
Merged

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Nov 4, 2022

Found a handful of unused imports.

The dependency on tkinter was also unnecessary as it was only importing a single constant (which is not even used by Xlib). I kept the constant so this doesn't count as a breaking change (idk if it's meant to be part of the protocol).
Fixes #240

@fransklaver
Copy link

The constant isn't part of the protocol. It was IMO erroneously introduced in c87624d. I also remove this import in #242. I hadn't noticed your PR at the time.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #239 (25971f6) into master (333fbcb) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   78.25%   78.23%   -0.03%     
==========================================
  Files          42       42              
  Lines        4710     4704       -6     
==========================================
- Hits         3686     3680       -6     
  Misses       1024     1024              

@vasily-v-ryabov vasily-v-ryabov merged commit b091980 into python-xlib:master Dec 25, 2022
@Avasam Avasam deleted the unused-imports branch December 25, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary import
4 participants