randr: inherit XError in error classes #242

fransklaver · 2022-11-08T11:30:54Z

Commit c87624d ('Add Randr error classes and register them during init') introduces three new error classes to xrandr, but makes them inherit from Exception.

Let all error classes in randr inherit from Xerror, like all other code expects.

Fixes the traceback

...
      File "/tmp/python-env/lib/python3.8/site-packages/Xlib/display.py", line 182, in sync
        self.get_pointer_control()
      File "/tmp/python-env/lib/python3.8/site-packages/Xlib/display.py", line 833, in get_pointer_control
        return request.GetPointerControl(display = self.display)
      File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/rq.py", line 1369, in __init__
        self.reply()
      File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/rq.py", line 1381, in reply
        self._display.send_and_recv(request = self._serial)
      File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/display.py", line 612, in send_and_recv
        gotreq = self.parse_response(request)
      File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/display.py", line 719, in parse_response
        gotreq = self.parse_error_response(request) or gotreq
      File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/display.py", line 745, in parse_error_response
        req = self.get_waiting_request(e.sequence_number)
    AttributeError: 'BadRRModeError' object has no attribute 'sequence_number'

fixes #241

Avasam · 2022-11-16T18:42:00Z

I've noticed this as well while working on type definitions. extension_add_error should expect a XError, but BadRROutputError, BadRRCrtcError and BadRRModeError aren't.

What about the other Error classes?

fransklaver · 2022-11-18T12:00:27Z

What about the other Error classes?

I would expect that those errors also derive from xlib.XError if they are to be used as such.

They didn't crash my program, and as these specific classes had been added recently, I hadn't bothered to look any further. Feel free to fix the others too.

vasily-v-ryabov · 2022-12-25T18:33:52Z

@fransklaver thanks for the fix! Please resolve conflicts before merging it.

Commit c87624d ('Add Randr error classes and register them during init') introduces three new error classes to xrandr, but makes them inherit from Exception. Let all error classes in randr inherit from Xerror, like all other code expects. Fixes the traceback ``` ... File "/tmp/python-env/lib/python3.8/site-packages/Xlib/display.py", line 182, in sync self.get_pointer_control() File "/tmp/python-env/lib/python3.8/site-packages/Xlib/display.py", line 833, in get_pointer_control return request.GetPointerControl(display = self.display) File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/rq.py", line 1369, in __init__ self.reply() File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/rq.py", line 1381, in reply self._display.send_and_recv(request = self._serial) File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/display.py", line 612, in send_and_recv gotreq = self.parse_response(request) File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/display.py", line 719, in parse_response gotreq = self.parse_error_response(request) or gotreq File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/display.py", line 745, in parse_error_response req = self.get_waiting_request(e.sequence_number) AttributeError: 'BadRRModeError' object has no attribute 'sequence_number' ``` fixes python-xlib#241

codecov-commenter · 2022-12-25T21:25:55Z

Codecov Report

Merging #242 (52800b1) into master (4e8bbf8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   78.21%   78.21%           
=======================================
  Files          42       42           
  Lines        4705     4705           
=======================================
  Hits         3680     3680           
  Misses       1025     1025

petli · 2022-12-28T10:50:24Z

What about the other Error classes?

I would expect that those errors also derive from xlib.XError if they are to be used as such.

XError represents errors that are returned from the server and is deserialised from the protocol error message, while the other ones are client-side errors where none of that information is available. Thus it wouldn't make sense to use XError as the base for all exceptions in Xlib, but a new intermediary exception class could be introduced for that purpose if that would be useful (maybe XlibError or XlibException, or maybe there's some other recommendations in modern Python).

fransklaver · 2022-12-28T12:49:37Z

What about the other Error classes?

I would expect that those errors also derive from xlib.XError if they are to be used as such.

XError represents errors that are returned from the server and is deserialised from the protocol error message, while the other ones are client-side errors where none of that information is available. Thus it wouldn't make sense to use XError as the base for all exceptions in Xlib, but a new intermediary exception class could be introduced for that purpose if that would be useful (maybe XlibError or XlibException, or maybe there's some other recommendations in modern Python).

That's basically what I meant, yes. If they won't be treated like they're XErrors, there is no point in having them inherit XError. For clarity it could be useful to introduce an intermediate layer, I agree.

petli · 2022-12-28T14:15:31Z

That's basically what I meant, yes. If they won't be treated like they're XErrors, there is no point in having them inherit XError.

I see, sorry for the misunderstanding! My brain haven't fully booted up today.

fransklaver · 2022-12-28T14:17:14Z

I see, sorry for the misunderstanding! My brain haven't fully booted up today.

No worries. It only clarifies stuff for other people whose brains haven't fully booted yet ;).

In python-xlib 0.32, the bug python-xlib/python-xlib#242 was introduced which caused `test_floatplacement_smart_create_many` to fail deterministically. There already is a pull request in `python-xlib` with a fix, but it is not merged yet. So for the time being, let's simply use the old python-xlib version.

ErikBjare · 2023-08-28T19:08:37Z

Is this not being considered for merging? We're facing #241 / #259 in our project where our end-users have spuriously had processes hang at 100% CPU until restarted.

We are considering pinning 0.31 until a fix is released. However, we ourselves have a slow release cycle with lots of testing/prereleases, so hoping someone can pick this up before we ship a stable one. (as others seem to have done already in herbstluftwm/herbstluftwm#1544)

ErikBjare · 2023-09-13T07:49:00Z

@vasily-v-ryabov Any chance this will be considered for merge? Or should I just downgrade?

fransklaver · 2023-09-13T08:00:54Z

@ErikBjare We've had the version pinned to 0.31 ever since I stumbled upon this issue. The previous release should really have included this fix, and upon request I updated the pull request as soon as I could. I haven't had any further communication about this from @vasily-v-ryabov either.

@vasily-v-ryabov do you need help maintaining this project?

ErikBjare · 2023-09-13T08:02:58Z

Looking at the commit history there have been no new commits on master since December?

Not holding my breath. Saw that last commits were co-authored by Vasily, figured I would ping.

Given the stability of the Xorg/xlib APIs we use, we might keep the version pinned for a long time to prevent further issues (as issues would lead to data loss in our case).

ehfd · 2023-11-25T08:08:37Z

@benoit-pierre do you also have write access to this repository?

redhog · 2024-04-29T19:34:26Z

Heys! I was planning to make a PR for some convenience syntax sugar stuff, but the commit history of master and the above comments don't look promising / makes this look pointless. What is the plan for maintaining this library? Does anybody know?

fransklaver · 2024-05-01T07:13:37Z

I have no idea what the plan is for this repository.

ErikBjare · 2024-05-01T07:27:06Z

Neither do I, but I wouldn't expect such a PR to get merged. At least not any time soon.

ehfd · 2024-05-01T09:18:04Z

https://github.com/selkies-project/python-xlib/pulls?q=is%3Apr

I just merged all trivial PRs to my organization's fork. I can give out write access. @Avasam @fransklaver

Use python-xlib @ https://github.com/selkies-project/python-xlib/archive/master.zip for setuptools or pip.

Avasam · 2024-05-02T05:22:00Z

@ehfd This repo does look unmaintained, if not abandoned. I'm mostly interested in #251 . Which I could rewrite much better if you're willing to drop EOL Python (or at least anything under 3.7)

In the mean time, I added stubs to typeshed: https://pypi.org/project/types-python-xlib/

ehfd · 2024-05-02T07:06:33Z

@Avasam
I had to revert your commits (but nonetheless preserved this one) because one of them showed some new regressions with my project with capturing the cursor image consistently. I'd like to check which commit it is when I have time.

Would be grateful if you could help out advancing the fork in any way and testing its reliability.

petli · 2024-07-05T13:36:33Z

Speaking as the original author and lapsed maintainer (e.g. coming very late to this thread) this library would really need some active maintainers. I don't use XWindows anymore myself, and I think @vasily-v-ryabov has said something along the same lines.

fransklaver · 2024-07-05T13:42:33Z

@petli are you in a position to do something about the maintainer issue? Or would we need to contact @vasily-v-ryabov for that?

petli · 2024-07-05T13:46:03Z

@fransklaver I think I count as a maintainer still and could add new ones to the project. I would have to look at pypi publishing, I'm not sure if I have any permissions there. Maybe move this into a discussion thread for visibility?

fransklaver · 2024-07-05T14:03:43Z

@petli That sounds like a good idea, not sure where or how at this point, though

ehfd · 2024-07-05T14:05:38Z

@petli @fransklaver Discussions are not available in the GitHub repository, apparently (need to enable). Really keen about someone being able to maintain.

petli · 2024-07-08T15:59:17Z

@ehfd @fransklaver I've enabled discussions now, wasn't aware that I needed to do it first, and posted #273 there.

fransklaver force-pushed the randr-errors-inherit-xerror branch 2 times, most recently from ef0cc66 to 9a6fc9c Compare November 8, 2022 11:46

fransklaver mentioned this pull request Nov 8, 2022

Removed unused imports #239

Merged

Avasam mentioned this pull request Nov 17, 2022

py.typed and type comments #251

Draft

fransklaver force-pushed the randr-errors-inherit-xerror branch from 9a6fc9c to 52800b1 Compare December 25, 2022 21:24

t-wissmann mentioned this pull request Mar 9, 2023

Stick to old python-xlib in CI until bugfix herbstluftwm/herbstluftwm#1544

Merged

ErikBjare mentioned this pull request Aug 28, 2023

[Linux] 'BadRRModeError' object has no attribute 'sequence_number' ActivityWatch/aw-watcher-window#89

Closed

RedBearAK mentioned this pull request Aug 29, 2023

Random crash at X11 joshgoebel/keyszer#161

Open

ErikBjare mentioned this pull request Sep 13, 2023

0.32 throws AttributeError: 'BadRRModeError' object has no attribute 'sequence_number' #241

Open

cruizba mentioned this pull request Nov 23, 2023

Use version 0.31 of python-xlib to fix regression selkies-project/selkies#113

Closed

thegravelinspector mentioned this pull request Feb 5, 2024

keyd-application-mapper -d sometimes uses 100% CPU until it gets restarted rvaiya/keyd#553

Open

ehfd mentioned this pull request May 1, 2024

selkies-gstream hit 100% CPU selkies-project/docker-nvidia-egl-desktop#33

Closed

sdht0 mentioned this pull request Apr 3, 2025

activitywatch: newer xlib dependency causing process to fail NixOS/nixpkgs#395872

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

randr: inherit XError in error classes #242

randr: inherit XError in error classes #242

fransklaver commented Nov 8, 2022 •

edited

Loading

Avasam commented Nov 16, 2022 •

edited

Loading

fransklaver commented Nov 18, 2022

vasily-v-ryabov commented Dec 25, 2022

codecov-commenter commented Dec 25, 2022

petli commented Dec 28, 2022

fransklaver commented Dec 28, 2022

petli commented Dec 28, 2022

fransklaver commented Dec 28, 2022

ErikBjare commented Aug 28, 2023 •

edited

Loading

ErikBjare commented Sep 13, 2023

fransklaver commented Sep 13, 2023

ErikBjare commented Sep 13, 2023 •

edited

Loading

ehfd commented Nov 25, 2023

redhog commented Apr 29, 2024

fransklaver commented May 1, 2024

ErikBjare commented May 1, 2024

ehfd commented May 1, 2024 •

edited

Loading

Avasam commented May 2, 2024

ehfd commented May 2, 2024 •

edited

Loading

petli commented Jul 5, 2024

fransklaver commented Jul 5, 2024

petli commented Jul 5, 2024

fransklaver commented Jul 5, 2024

ehfd commented Jul 5, 2024 •

edited

Loading

petli commented Jul 8, 2024

randr: inherit XError in error classes #242

Are you sure you want to change the base?

randr: inherit XError in error classes #242

Conversation

fransklaver commented Nov 8, 2022 • edited Loading

Avasam commented Nov 16, 2022 • edited Loading

fransklaver commented Nov 18, 2022

vasily-v-ryabov commented Dec 25, 2022

codecov-commenter commented Dec 25, 2022

Codecov Report

petli commented Dec 28, 2022

fransklaver commented Dec 28, 2022

petli commented Dec 28, 2022

fransklaver commented Dec 28, 2022

ErikBjare commented Aug 28, 2023 • edited Loading

ErikBjare commented Sep 13, 2023

fransklaver commented Sep 13, 2023

ErikBjare commented Sep 13, 2023 • edited Loading

ehfd commented Nov 25, 2023

redhog commented Apr 29, 2024

fransklaver commented May 1, 2024

ErikBjare commented May 1, 2024

ehfd commented May 1, 2024 • edited Loading

Avasam commented May 2, 2024

ehfd commented May 2, 2024 • edited Loading

petli commented Jul 5, 2024

fransklaver commented Jul 5, 2024

petli commented Jul 5, 2024

fransklaver commented Jul 5, 2024

ehfd commented Jul 5, 2024 • edited Loading

petli commented Jul 8, 2024

fransklaver commented Nov 8, 2022 •

edited

Loading

Avasam commented Nov 16, 2022 •

edited

Loading

ErikBjare commented Aug 28, 2023 •

edited

Loading

ErikBjare commented Sep 13, 2023 •

edited

Loading

ehfd commented May 1, 2024 •

edited

Loading

ehfd commented May 2, 2024 •

edited

Loading

ehfd commented Jul 5, 2024 •

edited

Loading