Skip to content

Project files tune-up #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 11, 2017
Merged

Project files tune-up #320

merged 11 commits into from
Jan 11, 2017

Conversation

vmuriart
Copy link
Contributor

@vmuriart vmuriart commented Jan 9, 2017

  • Maintenance to the project to remove many unneeded files. Commit history references when/why its safe to remove the files.
  • Added a CHANGELOG
  • Cleaned up project references to files
  • Cleaned up a couple warnings and tests

Overall it makes the project look alot less intimidating

@vmuriart vmuriart self-assigned this Jan 9, 2017
@vmuriart
Copy link
Contributor Author

vmuriart commented Jan 9, 2017

@tonyroberts what's the purpose of clrmodule.il?

It looks like nothing references it anymore, and everything still passed after I removed it, but I didn't want to remove it since I couldn't understand its purpose.

@filmor
Copy link
Member

filmor commented Jan 9, 2017

I like this PR a lot, keep going :)

@filmor filmor mentioned this pull request Jan 9, 2017
9 tasks
@tonyroberts
Copy link
Contributor

@vmuriart re: clrmodule.il, I think this and related files (clrmodule.pp.il, oldmodule.il, buildclrmodule.bat) can be safely deleted. They're from before I started looking at this project, but from what I can gather they're legacy code that has since been replaced by clrmodule.cs.

@vmuriart
Copy link
Contributor Author

vmuriart commented Jan 9, 2017

@tonyroberts you're right.

@vmuriart
Copy link
Contributor Author

vmuriart commented Jan 9, 2017

I think this pr is ready for merging. There's still a bit more to clean-up within the src itself, but I don't want to mix those in with this pr.

Let me know if there's any objections with merging it in. For this particular pr I'd prefer we do a merge commit to a copy of commit messages since they explain the reasoning for each file deletion.

@vmuriart vmuriart mentioned this pull request Jan 9, 2017
- `./htdocs/*` duplicates the content of `pythonnet.github.io`
- `./installer/*` isn't used for distribution anymore
- `pythonnet.build` is no longer used as build method.
- `*.{mds,,mdp}` are deprecated mono files. Deprecated since eff40df
- `pythonnet_8.sln` old solution file
- `pythonnet_9.sln` old solution file
- `doc/mono_config.txt` outdate version of `.\Python.Runtime.dll.config`
- `doc/Python.Runtime.dll.config` outdate version of `.\Python.Runtime.dll.config`
- `visualstate` is a per user setting. https://groups.google.com/forum/#!topic/nunit-discuss/7aXg_usr98Q
Relevant items from todo.txt were opened as tickets
`sourceforge-logo.png` not sure why it existed
`clrmodule.pp.il` used to be part of the makefile build to create `clrmodule.il`. No longer used.
`oldmodule.il` is an old copy of `clrmodule.il` commit: 927bbf1
- Add reference to py3.3 and py3.6 interop files
- Add missing preprocessor to py3.3 interop
- Remove unused build script. Unref on commit: 5300343

Note, looks like nothing uses `clrmodule.il` anymore. Leaving it for now.
- Remove py32 classifier
- Stop testing on unsupported python versions
- Add python33 testing
- Changed check_output to _check_output
> warning : The project configuration for project 'clrmodule' corresponding to the solution configuration 'ReleaseMono|x64' was not found.
@vmuriart
Copy link
Contributor Author

@denfromufa @filmor @tonyroberts any objections to merging this in?

@filmor
Copy link
Member

filmor commented Jan 11, 2017

Is it fine to merge this squashed?

@vmuriart vmuriart merged commit 5f6e16c into pythonnet:master Jan 11, 2017
@vmuriart vmuriart deleted the cleanup-files branch January 11, 2017 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants