-
Notifications
You must be signed in to change notification settings - Fork 748
Project files tune-up #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tonyroberts what's the purpose of It looks like nothing references it anymore, and everything still passed after I removed it, but I didn't want to remove it since I couldn't understand its purpose. |
I like this PR a lot, keep going :) |
@vmuriart re: clrmodule.il, I think this and related files (clrmodule.pp.il, oldmodule.il, buildclrmodule.bat) can be safely deleted. They're from before I started looking at this project, but from what I can gather they're legacy code that has since been replaced by clrmodule.cs. |
I think this Let me know if there's any objections with merging it in. For this particular |
48ce04b
to
e458822
Compare
- `./htdocs/*` duplicates the content of `pythonnet.github.io` - `./installer/*` isn't used for distribution anymore - `pythonnet.build` is no longer used as build method. - `*.{mds,,mdp}` are deprecated mono files. Deprecated since eff40df - `pythonnet_8.sln` old solution file - `pythonnet_9.sln` old solution file - `doc/mono_config.txt` outdate version of `.\Python.Runtime.dll.config` - `doc/Python.Runtime.dll.config` outdate version of `.\Python.Runtime.dll.config` - `visualstate` is a per user setting. https://groups.google.com/forum/#!topic/nunit-discuss/7aXg_usr98Q
Relevant items from todo.txt were opened as tickets
`sourceforge-logo.png` not sure why it existed `clrmodule.pp.il` used to be part of the makefile build to create `clrmodule.il`. No longer used. `oldmodule.il` is an old copy of `clrmodule.il` commit: 927bbf1
- Add reference to py3.3 and py3.6 interop files - Add missing preprocessor to py3.3 interop - Remove unused build script. Unref on commit: 5300343 Note, looks like nothing uses `clrmodule.il` anymore. Leaving it for now.
- Remove py32 classifier - Stop testing on unsupported python versions - Add python33 testing - Changed check_output to _check_output
> warning : The project configuration for project 'clrmodule' corresponding to the solution configuration 'ReleaseMono|x64' was not found.
Replace by `clrmodule.cs` on commit 74e178c https://github.com/pythonnet/pythonnet/blob/a330330104695581165de388279830204604bcf9/src/clrmodule/ClrModule.cs#L2-L3
e458822
to
d711bd8
Compare
@denfromufa @filmor @tonyroberts any objections to merging this in? |
Is it fine to merge this squashed? |
Overall it makes the project look alot less intimidating