Fix memory leaks due to spurious handle increment and add unit tests #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
=========================================
+ Coverage 76.94% 77.4% +0.45%
=========================================
Files 63 63
Lines 5592 5589 -3
Branches 892 892
=========================================
+ Hits 4303 4326 +23
+ Misses 998 970 -28
- Partials 291 293 +2
Continue to review full report at Codecov.
|
|
There are probably more issues like this in the code, essentially every class derived from |
|
Thank you very much for your contribution :) |
|
@filmor thanks for the merge. Any indication as to when the next release might happen? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Fix memory leaks due to spurious handle increment and add unit tests
...
Does this close any currently open issues?
Issue #691
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG