[BE] bump `optree` version to 0.12.1 #130139

XuehaiPan · 2024-07-05T05:07:28Z

Stack from ghstack (oldest at bottom):

0.12.0 Major Updates:

Add context manager to temporarily set the dictionary sorting mode
Add accessor APIs
Use stable tag for pybind11 for Python 3.13 support
Fix potential segmentation fault for pickling support

0.12.1 Updates:

Fix warning regression during import when launch with strict warning filters

Closes #130155

[ghstack-poisoned]

pytorch-bot · 2024-07-05T05:07:30Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130139

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit f559691 with merge base 3c622fb ():

CANCELLED JOB - The following job was cancelled. Please retry:

Mac MPS / macos-py3-arm64-mps / test (mps, 1, 1, macos-m2-14) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

clee2000 · 2024-07-05T17:19:34Z

Please also pin optree in windows CI

pytorch/.github/workflows/_win-test.yml

Line 191 in a33ee73

python3 -mpip install $(echo *.whl)[opt-einsum,optree]

The update to 0.12.0 got picked up and is currently failing. I have #130155 to pin it to 0.11.0 to restore the current CI if this takes too long to merge

XuehaiPan · 2024-07-05T17:27:08Z

torch/utils/_cxx_pytree.py

@@ -273,7 +273,7 @@ def tree_flatten(
    >>> from collections import OrderedDict
    >>> tree = OrderedDict([('b', (2, [3, 4])), ('a', 1), ('c', None), ('d', 5)])
    >>> tree_flatten(tree)
-    ([2, 3, 4, 1, None, 5], PyTreeSpec(OrderedDict([('b', (*, [*, *])), ('a', *), ('c', *), ('d', *)]), NoneIsLeaf))
+    ([2, 3, 4, 1, None, 5], PyTreeSpec(OrderedDict({'b': (*, [*, *]), 'a': *, 'c': *, 'd': *}), NoneIsLeaf))


The update to 0.12.0 got picked up and is currently failing.

@clee2000 The doctest fix is included.

[ghstack-poisoned]

0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters ghstack-source-id: c80bc58 Pull Request resolved: pytorch#130139

XuehaiPan · 2024-07-18T17:47:03Z

Is this new pytree version working with 3.13t ?

Yes, it is tested against Python 3.13t.

[ghstack-poisoned]

0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters ghstack-source-id: 473f570 Pull Request resolved: pytorch#130139

test/functorch/test_eager_transforms.py

XuehaiPan · 2024-07-20T02:33:58Z

@pytorchbot merge -i

pytorchmergebot · 2024-07-20T02:35:45Z

Merge started

Your change will be merged while ignoring the following 1 checks: Mac MPS / macos-py3-arm64-mps / test (mps, 1, 1, macos-m2-14)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Pull Request resolved: #130144 Approved by: https://github.com/zou3519 ghstack dependencies: #130895, #130139

0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters Closes pytorch#130155 Pull Request resolved: pytorch#130139 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895

Pull Request resolved: pytorch#130144 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895, pytorch#130139

0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters Closes pytorch#130155 Pull Request resolved: pytorch#130139 Approved by: https://github.com/zou3519

This reverts commit 8fcb156. Reverted pytorch#130139 on behalf of https://github.com/clee2000 due to broke inductor/test_torchinductor_codegen_dynamic_shapes.py and test_sympy_utils.py https://hud.pytorch.org/pytorch/pytorch/commit/8fcb156e8b5697a8f292db6db2a1803c5f4ce2d7 ([comment](pytorch#130139 (comment)))

0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters Closes pytorch#130155 Pull Request resolved: pytorch#130139 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895

Pull Request resolved: pytorch#130144 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895, pytorch#130139

Update

9247528

[ghstack-poisoned]

XuehaiPan requested review from a team and jeffdaily as code owners July 5, 2024 05:07

pytorch-bot bot added the topic: not user facing topic category label Jul 5, 2024

This was referenced Jul 5, 2024

[pytree][Easy] preserve dict keys in insertion order in CXX pytree #130140

Closed

[pytree] implement key path APIs for CXX pytree #130141

Closed

[pytree] enable CXX pytree under torch::deploy #130142

Closed

XuehaiPan added release notes: releng release notes category ciflow/trunk Trigger trunk jobs on your pull request labels Jul 5, 2024

pytorchbot added the open source label Jul 5, 2024

Update

b4f8261

[ghstack-poisoned]

XuehaiPan mentioned this pull request Jul 5, 2024

[Easy][pytree] enable CXX pytree under torch::deploy #130144

Closed

XuehaiPan requested review from kulinseth and malfet as code owners July 5, 2024 08:31

pytorch-bot bot added the ciflow/mps Run MPS tests (subset of trunk) label Jul 5, 2024

XuehaiPan added 4 commits July 5, 2024 16:37

Update

1fa9ce4

[ghstack-poisoned]

Update

630906f

[ghstack-poisoned]

Update

0c8aaef

[ghstack-poisoned]

Update

663e8a8

[ghstack-poisoned]

XuehaiPan mentioned this pull request Jul 5, 2024

Add linux manywheel python 3.13 binary workflows #130030

Closed

XuehaiPan commented Jul 5, 2024

View reviewed changes

XuehaiPan requested review from huydhn, atalman and clee2000 July 5, 2024 17:28

Update

faaaab7

[ghstack-poisoned]

XuehaiPan changed the title ~~[BE] bump optree version to 0.12.0~~ [BE] bump optree version to 0.12.1 Jul 6, 2024

XuehaiPan added 2 commits July 7, 2024 00:58

Update

966245c

[ghstack-poisoned]

Update

765ce5f

[ghstack-poisoned]

Update

31c52ad

[ghstack-poisoned]

Update

a137f2e

[ghstack-poisoned]

Update

7101879

[ghstack-poisoned]

XuehaiPan mentioned this pull request Jul 19, 2024

[BE][tests] show local variables on failure in tests #131151

Closed

Update

f559691

[ghstack-poisoned]

albanD reviewed Jul 19, 2024

View reviewed changes

test/functorch/test_eager_transforms.py Show resolved Hide resolved

pytorchmergebot added the merging label Jul 20, 2024

pytorchmergebot closed this in d2bd9ac Jul 20, 2024

pytorchmergebot removed the merging label Jul 20, 2024

pytorchmergebot pushed a commit that referenced this pull request Jul 21, 2024

[Easy][pytree] enable CXX pytree under torch::deploy (#130144)

1439bd3

Pull Request resolved: #130144 Approved by: https://github.com/zou3519 ghstack dependencies: #130895, #130139

henrylhtsang mentioned this pull request Jul 31, 2024

[BE][typing] fix types in common pruning #132309

Closed

albanD mentioned this pull request Aug 6, 2024

[Not to be merged] Update to compile and run test_torch with 3.13t #130689

Closed

9 tasks

github-actions bot deleted the gh/XuehaiPan/107/head branch August 20, 2024 01:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[BE] bump `optree` version to 0.12.1 #130139

[BE] bump `optree` version to 0.12.1 #130139

Uh oh!

XuehaiPan commented Jul 5, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jul 5, 2024 •

edited

Loading

Uh oh!

clee2000 commented Jul 5, 2024 •

edited

Loading

Uh oh!

XuehaiPan Jul 5, 2024

Uh oh!

XuehaiPan commented Jul 18, 2024

Uh oh!

Uh oh!

XuehaiPan commented Jul 20, 2024

Uh oh!

pytorchmergebot commented Jul 20, 2024

Uh oh!

Uh oh!

[BE] bump optree version to 0.12.1 #130139

[BE] bump optree version to 0.12.1 #130139

Uh oh!

Conversation

XuehaiPan commented Jul 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130139

❌ 1 Cancelled Job

Uh oh!

clee2000 commented Jul 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XuehaiPan Jul 5, 2024

Choose a reason for hiding this comment

Uh oh!

XuehaiPan commented Jul 18, 2024

Uh oh!

Uh oh!

XuehaiPan commented Jul 20, 2024

Uh oh!

pytorchmergebot commented Jul 20, 2024

Merge started

Uh oh!

Uh oh!

[BE] bump `optree` version to 0.12.1 #130139

[BE] bump `optree` version to 0.12.1 #130139

XuehaiPan commented Jul 5, 2024 •

edited

Loading

pytorch-bot bot commented Jul 5, 2024 •

edited

Loading

clee2000 commented Jul 5, 2024 •

edited

Loading