-
Notifications
You must be signed in to change notification settings - Fork 24.9k
[BE][tests] show local variables on failure in tests #131151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131151
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6c64040 with merge base be3eba3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: 0ea4513 Pull Request resolved: pytorch#131151
I'll sign off on this, but I'd like someone from dev infra to be aware that this is going in. mmmmm @atalman I choose you! |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
I set the default to |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ghstack-source-id: 59baac8 Pull Request resolved: pytorch#131151
…l test log verbosity (#131981)" This reverts commit dfa18bf. Reverted #131981 on behalf of https://github.com/atalman due to Sorry, need to revert bottom PR, which broke CI: #131151 ([comment](#131981 (comment)))
…og verbosity (#131981) Add a new label `ci-test-showlocals` and add it to test config filter. If the PR is labeled with `ci-test-showlocals` or "ci-test-showlocals" present in the PR comment, the test config filter will set a environment variable `TEST_SHOWLOCALS`. Then `pytest` will show local variables on failures for better debugging. Pull Request resolved: #131981 Approved by: https://github.com/malfet
@pytorchmergebot revert -c nosignal -m "Broke CI: test_testing.py::TestTestingCUDA::test_cuda_assert_should_stop_common_device_type_test_suite_cuda GH job link HUD commit link" |
@pytorchbot successfully started a revert job. Check the current status here. |
@XuehaiPan your PR has been successfully reverted. |
This reverts commit 14158d8. Reverted #131151 on behalf of https://github.com/atalman due to Broke CI: test_testing.py::TestTestingCUDA::test_cuda_assert_should_stop_common_device_type_test_suite_cuda [GH job link](https://github.com/pytorch/pytorch/actions/runs/10131415299/job/28014665693) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/14158d892a2bd9b34edb5637f9a05217ea0330bd) ([comment](#131151 (comment)))
…og verbosity (#131981) Add a new label `ci-test-showlocals` and add it to test config filter. If the PR is labeled with `ci-test-showlocals` or "ci-test-showlocals" present in the PR comment, the test config filter will set a environment variable `TEST_SHOWLOCALS`. Then `pytest` will show local variables on failures for better debugging. Pull Request resolved: #131981 Approved by: https://github.com/malfet ghstack dependencies: #131151
ghstack-source-id: 4dff356 Pull Request resolved: pytorch#131151
Stack from ghstack (oldest at bottom):
ci-test-showlocals
to control test log verbosity #131981As per the title, add argument
--locals
forunittest
and--showlocals --tb=long
forpytest
in CI.Some failures cannot be reproduced on the local machine but exist on cloud CI. This change allows us to investigate the test failure more easily.
Example output: https://github.com/pytorch/pytorch/actions/runs/9961546996/job/27523888353?pr=130710#step:20:3361
cc @seemethere @malfet @pytorch/pytorch-dev-infra @mruberry @ZainRizvi