Skip to content

Remove shebang line from easy_install generated python scripts on Windows only (#108602) #139618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove shebang line from easy_install generated python scripts on Windows only (#108602) #139618

wants to merge 1 commit into from

Conversation

taras-janea
Copy link
Collaborator

@taras-janea taras-janea commented Nov 4, 2024 •
edited by pytorch-bot bot
Loading

Fixes

On windows only, for install step: remove shebang line from python scripts generated by easy_install.

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 4, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139618

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit d9cb0ed with merge base 002accf (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@taras-janea
Copy link
Collaborator Author

@pytorchbot label "module: windows"

@pytorch-bot pytorch-bot bot added the module: windows Windows support for PyTorch label Nov 4, 2024
@taras-janea
Copy link
Collaborator Author

@pytorchbot label "topic: bug fixes"

@pytorch-bot pytorch-bot bot added the topic: bug fixes topic category label Nov 4, 2024
@kalaskarsanket kalaskarsanket requested a review from malfet November 5, 2024 16:15
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jan 7, 2025
@taras-janea taras-janea removed the Stale label Jan 7, 2025
@kalaskarsanket
Copy link
Collaborator

@malfet Checking review status on this PR

@taras-janea
Copy link
Collaborator Author

Closing in favor of #148673 with permissions granted to pytorchmergebot

@taras-janea taras-janea closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
module: windows Windows support for PyTorch open source topic: bug fixes topic category topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taras-janea @kalaskarsanket @bdhirsh @pytorchbot