Skip to content

Remove shebang line from easy_install generated python scripts on Windows only #148673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

taras-janea
Copy link
Collaborator

@taras-janea taras-janea commented Mar 6, 2025

Fixes

On windows only, for install step: remove shebang line from python scripts generated by easy_install.

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex

Copy link

pytorch-bot bot commented Mar 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148673

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit a3eefe0 with merge base c0f1557 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@taras-janea
Copy link
Collaborator Author

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased pytorch-108602 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout pytorch-108602 && git pull --rebase)

@colesbury colesbury requested a review from malfet March 6, 2025 18:36
@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 6, 2025
@taras-janea
Copy link
Collaborator Author

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased pytorch-108602 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout pytorch-108602 && git pull --rebase)

@malfet
Copy link
Contributor

malfet commented Mar 19, 2025

@taras-janea Is this reproductive for wheel or conda builds? And if easy_install is deprecated, perhaps better solution would be to move to a supported framework ?

@taras-janea
Copy link
Collaborator Author

@taras-janea Is this reproductive for wheel or conda builds? And if easy_install is deprecated, perhaps better solution would be to move to a supported framework ?

@malfet thank you for your question. This is reproductive for conda distributions from https://conda.anaconda.org - they already contain an invalid absolute shebang line.

Regarding deprecated easy_install module, it's not used directly in PyTorch, but is used by setuptools which in turn is used by setup.py. I agree that removing the easy_install dependency would be beneficial.

Regardless, the changes in the PR are still needed to ensure the invalid shebang line is removed, as it is already present in conda distributions. You may find more details in the issue comment.

Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@iremyux
Copy link
Collaborator

iremyux commented Aug 5, 2025

Adding ciflow/win-arm64 label to trigger Windows Arm64 CI and its test purposes - nothing about this PR specifically.

@iremyux iremyux added the ciflow/win-arm64 Trigger Windows Arm64 CI Workflows label Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/win-arm64 Trigger Windows Arm64 CI Workflows module: windows Windows support for PyTorch open source topic: bug fixes topic category topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants