Add make_dynamo_test
#146491
Closed
Add make_dynamo_test
#146491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146491
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 3 Pending, 5 Unrelated FailuresAs of commit 98cc85f with merge base b18e3c0 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 5, 2025
Closed
Closed
zou3519
approved these changes
Feb 5, 2025
test/dynamo/utils.py
Outdated
| @@ -60,3 +62,39 @@ def install_guard_manager_testing_hook(hook_fn): | |||
| yield | |||
| finally: | |||
| torch._dynamo.guards.guard_manager_testing_hook_fn = old_value | |||
|
|
|||
|
|
|||
| def make_dynamo_test(fn=None, expected_frame_count=1): | |||
There was a problem hiding this comment.
add docstring about how dynamo needs a tensor operation to do anything
There was a problem hiding this comment.
Btw after #146527 we don't actually need to insert the .sin() calls
anijain2305
approved these changes
Feb 5, 2025
Skylion007
reviewed
Feb 6, 2025
test/dynamo/utils.py
Outdated
|
|
||
| def standard_test( | ||
| self: Any, | ||
| fn: Callable[..., Any], |
There was a problem hiding this comment.
Why not use ParamSpec, and TypeVar to preserve Callable inputs and return type
zou3519
reviewed
Feb 10, 2025
Comment on lines
1735
to
1736
| Dynamo injects a dummy call to `torch.sin(random_tensor)` to ensure graph | ||
| generation, even when testing for side effects. |
There was a problem hiding this comment.
Since we're here now and #146527 has landed, there's no need for the .sin calls anymore
malfet
approved these changes
Feb 10, 2025
zou3519
approved these changes
Feb 12, 2025
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
desai0007
pushed a commit
to desai0007/test-repo-pytorch
that referenced
this pull request
Feb 26, 2025
ghstack-source-id: ed7c165 Pull Request resolved: pytorch/pytorch#146491
desai0007
pushed a commit
to desai0007/test-repo-pytorch
that referenced
this pull request
Feb 26, 2025
ghstack-source-id: 7b1c151 Pull Request resolved: pytorch/pytorch#146491
desai0007
pushed a commit
to desai0007/test-repo-pytorch
that referenced
this pull request
Feb 26, 2025
ghstack-source-id: a7b1d8d Pull Request resolved: pytorch/pytorch#146491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
__context/cause/suppress_context/traceback__to Exception #146499UserDefinedExceptionClassVariable#146504AttributeErrorto user code in user_defined.py #146497is/is not#146496RAISE_VARARGS 0#146493WITH_EXCEPT_STARTopcode #146492sys.exc_infoandsys.exception#146498make_dynamo_test#146491cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames