Fix STOPITERATION_ERROR opcode #146494
Closed
Fix STOPITERATION_ERROR opcode #146494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146494
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 2 Unrelated FailuresAs of commit ba99230 with merge base 9da376d ( NEW FAILURE - The following job has failed:
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 5, 2025
Closed
Closed
Closed
anijain2305
reviewed
Feb 5, 2025
| assert isinstance(inst, ExceptionVariable) | ||
| if inst.exc_type is StopIteration: | ||
| exc.raise_observed_exception(RuntimeError, self) | ||
| tos = self.stack[-1] |
There was a problem hiding this comment.
Nit: Prefer to pop and then push the new exception into the stack.
desai0007
pushed a commit
to desai0007/test-repo-pytorch
that referenced
this pull request
Feb 26, 2025
ghstack-source-id: 4412fbc Pull Request resolved: pytorch/pytorch#146494
|
Closing as this one was fixed in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
UserDefinedExceptionClassVariable#146504__context/cause/suppress_context/traceback__to Exception #146499sys.exc_infoandsys.exception#146498AttributeErrorto user code in user_defined.py #146497is/is not#146496RAISE_VARARGS 0#146493WITH_EXCEPT_STARTopcode #146492make_dynamo_test#146491cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames