Skip to content

Propagate AttributeError to user code in user_defined.py #146497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

Propagate AttributeError to user code in user_defined.py #146497

wants to merge 16 commits into from

Conversation

guilhermeleobas
Copy link
Collaborator

@guilhermeleobas guilhermeleobas commented Feb 5, 2025 •
edited
Loading

@guilhermeleobas
Update
2447313 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146497

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a88b7a8 with merge base fd8ae1a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Feb 5, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
@guilhermeleobas guilhermeleobas marked this pull request as ready for review February 5, 2025 17:34
@guilhermeleobas
Update
e8638e4 
[ghstack-poisoned]
anijain2305
anijain2305 reviewed Feb 5, 2025
View reviewed changes
torch/_dynamo/variables/user_defined.py Outdated
@@ -183,7 +183,7 @@ def var_getattr(self, tx: "InstructionTranslator", name: str) -> "VariableTracke
try:
obj = inspect.getattr_static(self.value, name)
except AttributeError:
obj = None
raise_observed_exception(AttributeError, tx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can't do this for metaclasses

image

anijain2305
anijain2305 requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to check for metaclass __getattr__

@guilhermeleobas
Update
e5f7fa7 
[ghstack-poisoned]
@guilhermeleobas
Update
d86c575 
[ghstack-poisoned]
@guilhermeleobas
Update
c4698ca 
[ghstack-poisoned]
@guilhermeleobas
Update
6a660e6 
[ghstack-poisoned]
@guilhermeleobas
Update
d5b94c0 
[ghstack-poisoned]
@guilhermeleobas
Update
bea3da5 
[ghstack-poisoned]
@guilhermeleobas
Update
4d3de1d 
[ghstack-poisoned]
@guilhermeleobas
Update
9b0bfb6 
[ghstack-poisoned]
@guilhermeleobas
Update
5b64bcb 
[ghstack-poisoned]
@guilhermeleobas
Update
7b6fd2f 
[ghstack-poisoned]
@guilhermeleobas
Update
0e33d67 
[ghstack-poisoned]
@guilhermeleobas
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 22, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / unit-test / linux-jammy-cpu-py3.9-gcc11-inductor / test (inductor_amx, 2, 2, linux.8xlarge.amx)

Details for Dev Infra team Raised by workflow job

@guilhermeleobas
Update
a88b7a8 
[ghstack-poisoned]
@guilhermeleobas
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

desai0007 pushed a commit to desai0007/test-repo-pytorch that referenced this pull request Feb 26, 2025
@guilhermeleobas
Propagate AttributeError to user code in user_defined.py
8e7c4dd 
ghstack-source-id: 52c6428
Pull Request resolved: pytorch/pytorch#146497
desai0007 pushed a commit to desai0007/test-repo-pytorch that referenced this pull request Feb 26, 2025
@guilhermeleobas
Propagate AttributeError to user code in user_defined.py
6ec22bf 
ghstack-source-id: 0d52914
Pull Request resolved: pytorch/pytorch#146497
aditew01 pushed a commit that referenced this pull request Feb 28, 2025
@guilhermeleobas @aditew01
Propagate AttributeError to user code in user_defined.py (#146497)
196550d 
Pull Request resolved: #146497
Approved by: https://github.com/anijain2305, https://github.com/zou3519
ghstack dependencies: #146496
majing921201 pushed a commit to majing921201/pytorch that referenced this pull request Mar 4, 2025
@guilhermeleobas @majing921201
Propagate AttributeError to user code in user_defined.py (pytorch#1…
622f2f5 
…46497)

Pull Request resolved: pytorch#146497
Approved by: https://github.com/anijain2305, https://github.com/zou3519
ghstack dependencies: pytorch#146496
@github-actions github-actions bot deleted the gh/guilhermeleobas/98/head branch March 27, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zou3519 zou3519 zou3519 approved these changes

@anijain2305 anijain2305 anijain2305 approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guilhermeleobas @pytorchmergebot @zou3519 @anijain2305 @pytorchbot