Skip to content

Support contextlib.ExitStack #146506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 109 commits into
base: gh/guilhermeleobas/107/base
Choose a base branch
from
Open

Support contextlib.ExitStack #146506

wants to merge 109 commits into from

Conversation

guilhermeleobas
Copy link
Collaborator

@guilhermeleobas guilhermeleobas commented Feb 5, 2025 •
edited
Loading

@guilhermeleobas
Update
07c44ec 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146506

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit d2919e2 with merge base c5ec545 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@guilhermeleobas guilhermeleobas mentioned this pull request Feb 5, 2025
Closed
This was referenced Feb 5, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
guilhermeleobas added a commit that referenced this pull request Feb 5, 2025
@guilhermeleobas
Support contextlib.ExitStack
37f0145 
ghstack-source-id: 04b0c9e
Pull Request resolved: #146506
@guilhermeleobas
Update
e207012 
[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Feb 5, 2025
@guilhermeleobas
Support contextlib.ExitStack
d34db0c 
ghstack-source-id: 49c3f83
Pull Request resolved: #146506
guilhermeleobas
guilhermeleobas commented Feb 5, 2025
View reviewed changes
test/dynamo/test_exitstack.py Outdated
self.assertEqual(y.dtype, torch.float64)


class CPythonTestBaseExitStack:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing link to CPython https://github.com/python/cpython/blob/v3.13.1/Lib/test/test_contextlib.py

@guilhermeleobas
Update
718cfc6 
[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Feb 6, 2025
@guilhermeleobas
Support contextlib.ExitStack
a4af04a 
ghstack-source-id: f0f9b4d
Pull Request resolved: #146506
@guilhermeleobas
Update
521f112 
[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Feb 6, 2025
@guilhermeleobas
Support contextlib.ExitStack
fb49d5c 
ghstack-source-id: 067afd3
Pull Request resolved: #146506
@guilhermeleobas
Update
72620c9 
[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Feb 7, 2025
@guilhermeleobas
Support contextlib.ExitStack
fb8f5e5 
ghstack-source-id: 9e8cd7e
Pull Request resolved: #146506
@guilhermeleobas
Update
3e2b907 
[ghstack-poisoned]
guilhermeleobas added a commit to guilhermeleobas/pytorch that referenced this pull request Apr 7, 2025
@guilhermeleobas
Support contextlib.ExitStack
979a693 
ghstack-source-id: 6db770a
Pull Request resolved: pytorch#146506
@guilhermeleobas
Update
cbd4890 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Rebased gh/guilhermeleobas/116/orig onto refs/remotes/origin/viable/strict because #150466 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/146506)

Divigroup-RAP pushed a commit to Divigroup-RAP/PYTORCH that referenced this pull request Apr 22, 2025
@guilhermeleobas
Support contextlib.ExitStack
bdf1d05 
ghstack-source-id: 453a254
Pull Request resolved: pytorch/pytorch#146506
@guilhermeleobas
Update
44dfe3e 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas marked this pull request as ready for review April 24, 2025 15:38
@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jun 23, 2025
@guilhermeleobas
Update
e52b21b 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request Jun 24, 2025
Closed
@guilhermeleobas
Update
4e7fda3 
[ghstack-poisoned]
@guilhermeleobas
Update
f2444da 
[ghstack-poisoned]
@guilhermeleobas
Update
2072aa9 
[ghstack-poisoned]
@guilhermeleobas
Update
745ce65 
[ghstack-poisoned]
@guilhermeleobas
Update
4a70ff4 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas mentioned this pull request Jun 25, 2025
Closed
@guilhermeleobas
Update
dd973be 
[ghstack-poisoned]
This was referenced Jun 27, 2025
Open
Open
Open
@guilhermeleobas
Update
2cd2f81 
[ghstack-poisoned]
@guilhermeleobas
Update
6a8f325 
[ghstack-poisoned]
@guilhermeleobas
Update
bae10df 
[ghstack-poisoned]
@guilhermeleobas
Update
89a56cf 
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas requested a review from zou3519 July 8, 2025 21:31
@guilhermeleobas
Update
ca5057d 
[ghstack-poisoned]
@guilhermeleobas
Update
883a5e0 
[ghstack-poisoned]
@guilhermeleobas
Update
d2919e2 
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zou3519 zou3519 Awaiting requested review from zou3519

Assignees
No one assigned
Labels
ciflow/inductor module: dynamo open source release notes: dynamo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the ExitStack context manager (or a simplified version)
3 participants
@guilhermeleobas @pytorchmergebot @pytorchbot