Move token linter code into tools/linter/adaptors/_linter/ #148959
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148959
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e786e9c with merge base f84062f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Oh, sorry to bug you again @Skylion007 , but this is a pure refactoring in the middle of the other two that simply splits up the big Expect more token linter excitement in the coming weeks! |
|
@pytorchbot merge |
|
This PR needs to be approved by an authorized maintainer before merge. |
|
Hey, @Skylion007, just pinging you on this other refactoring that's blocking another pull you approved. :-) |
|
@Skylion007: sorry again to bug you: in a better world, this and the other refactoring on the linter you reviewed and was submitted would have been one pull request, but there's a maximum delta of 2000 lines... |
ghstack-source-id: a606e1a Pull Request resolved: pytorch#148959
|
@Skylion007 - sorry to keep bugging you 🙂 , it's a refactoring before the one you already approved! |
This is a pure refactoring - no executable code has changed.
This is preparatory to adding considerably more functionality to this small family of "token linters" (as I call them, because they tokenize Python programs and then use that to lint them).
I centralized the code that was previously hidden in the individual linters, and broken up the
_linter.pywhich became fairly huge.Stack from ghstack (oldest at bottom):