Skip to content

Move code out of individual token linters #152256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

rec
Copy link
Collaborator

@rec rec commented Apr 26, 2025

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Apr 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152256

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c259c5a with merge base 4cd6e96 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 26, 2025
@rec rec added suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) module: bc-breaking Related to a BC-breaking change labels Apr 26, 2025
@rec
Copy link
Collaborator Author

rec commented Apr 26, 2025

This is a second pure refactoring after the previous. I originally tried did this all in one pull request, but it broke the 2000 line delta rule.

This one brings in most of the functionality on the two linters (set_linter and docstring_linter) into the main linter subdirectory, so it can be used by the upcoming "multilinter" (which covers anything that can be reported on using tokenization.)

[ghstack-poisoned]
rec added a commit that referenced this pull request Apr 26, 2025
ghstack-source-id: 3f6533c
Pull Request resolved: #152256
@rec rec marked this pull request as ready for review April 28, 2025 11:51
[ghstack-poisoned]
[ghstack-poisoned]
rec added a commit that referenced this pull request Apr 29, 2025
ghstack-source-id: f245ba7
Pull Request resolved: #152256
[ghstack-poisoned]
rec added a commit that referenced this pull request Jun 23, 2025
ghstack-source-id: 149e094
Pull Request resolved: #152256
@ezyang
Copy link
Contributor

ezyang commented Jun 23, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 23, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rec added a commit to rec/pytorch that referenced this pull request Jun 23, 2025
ghstack-source-id: 149e094
Pull Request resolved: pytorch#152256
@github-actions github-actions bot deleted the gh/rec/146/head branch July 24, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: bc-breaking Related to a BC-breaking change open source suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants