Skip to content

[CUTLASS][WIP] Gate rowwise matmul CUTLASS kernels by compute capability #152642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[CUTLASS][WIP] Gate rowwise matmul CUTLASS kernels by compute capability #152642

wants to merge 2 commits into from

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented May 1, 2025 •
edited by pytorch-bot bot
Loading

Does this abate some compile-time warning spam?

cc @ptrblck @msaroufim @jerryzh168 @yanbing-j @vkuzo @albanD @kadeng @penguinwu

@eqy eqy requested a review from syed-ahmed as a code owner May 1, 2025 23:25
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152642

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures

As of commit c474c5b with merge base b6c5886 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: cuda release notes category label May 1, 2025
@eqy eqy added module: cuda Related to torch.cuda, and CUDA support in general open source topic: not user facing topic category module: floatx (formerly float8) For torch.float8_e5m2 and torch.float8_e4m3 and other sub 8-bit float types and removed release notes: cuda release notes category labels May 1, 2025
@albanD albanD self-requested a review May 2, 2025 14:01
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 2, 2025
Aidyn-A
Aidyn-A reviewed Jun 10, 2025
View reviewed changes
aten/src/ATen/native/cuda/RowwiseScaledMM.cu
@@ -498,6 +502,7 @@ void f8f8bf16_rowwise_impl_sm89(
at::Tensor w_scale,
std::optional<at::Tensor> bias,
at::Tensor out) {
#if (defined(__CUDA_ARCH__)) && (__CUDA_ARCH__ == 890)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failures are really strange. As if this condition was evaluated as false.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aidyn-A Aidyn-A Aidyn-A left review comments

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
module: cuda Related to torch.cuda, and CUDA support in general module: floatx (formerly float8) For torch.float8_e5m2 and torch.float8_e4m3 and other sub 8-bit float types open source Stale topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eqy @Aidyn-A @albanD