[hop schema] add schema.tree_spec to support pytree inputs #154191
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154191
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit a4273c4 with merge base 08d15d3 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 22, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
zou3519
reviewed
Jun 2, 2025
zou3519
reviewed
Jun 2, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
zou3519
reviewed
Jun 9, 2025
torch/_higher_order_ops/base_hop.py
Outdated
| @@ -197,6 +197,7 @@ def gen_schema(self, subgraph, *operands, **kwargs): | |||
| for out in output: | |||
| schema_gen.add_output(out) | |||
|
|
|||
| # schema_gen.add_schema_tree_spec(subgraph, *operands, **kwargs) | |||
There was a problem hiding this comment.
yeah, we no longer need this anymore. If no schema_tree_spec is added, we'll just treat it as None.
[ghstack-poisoned]
|
Starting merge as part of PR stack under #154192 |
[ghstack-poisoned]
|
Starting merge as part of PR stack under #154192 |
This was referenced Jun 10, 2025
|
Starting merge as part of PR stack under #154192 |
|
Starting merge as part of PR stack under #154192 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 11, 2025
Pull Request resolved: #154192 Approved by: https://github.com/zou3519 ghstack dependencies: #155261, #154072, #154191
thatgeeman
pushed a commit
to thatgeeman/pytorch-docathon
that referenced
this pull request
Jun 15, 2025
…54191) Pull Request resolved: pytorch#154191 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#155261, pytorch#154072
thatgeeman
pushed a commit
to thatgeeman/pytorch-docathon
that referenced
this pull request
Jun 15, 2025
…4192) Pull Request resolved: pytorch#154192 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#155261, pytorch#154072, pytorch#154191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):