allow check_input_alias_and_mutation_return_outputs to take FunctionalTensor input #154648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lTensor input [ghstack-poisoned]
This was referenced May 29, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154648
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 38 New Failures, 1 Unrelated FailureAs of commit 24d2700 with merge base 1258aac ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 29, 2025
…e FunctionalTensor input" [ghstack-poisoned]
…e FunctionalTensor input" [ghstack-poisoned]
zou3519
reviewed
Jun 2, 2025
Comment on lines
+97
to
+103
| ( | ||
| _, | ||
| _, | ||
| _, | ||
| mutated_inputs, | ||
| outputs, | ||
| ) = check_input_alias_and_mutation_return_outputs(gm, operands) |
There was a problem hiding this comment.
Do you have some explanation about why this is better? I don't have a good sense of what we're doing here.
There was a problem hiding this comment.
This is required by cond tests that does make_fx(torch.func.functionalize(cond)), where we want to gen_schema for cond. Yeah, the PR lacks some context. I'll merge it with the auto_functionalize cond pr.
…e FunctionalTensor input" [ghstack-poisoned]
|
Not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):