🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156596

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 20063b1 with merge base ff0d56d ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

The postmortem as to how I thought I fixed this issue but didn't is a bit embarrassing.

I wrote code to extract decorators and query for @override and wrote a "test"
for that but I didn't hook it up to the actual place where I test if a docstring is necessary.

The test didn't fail because of another latent issue - when I counted the lines in a method or class, I started on the first indent after the definition, which did not include any introductory comments starting with #, so the method appeared short enough not to need a docstring!

I changed the definition of the length of a class or method to include the class or def statement, but not any blank lines after the class, function or method. This is more realistic, but tended to make everything a bit longer, so I increased the acceptable lengths in the test harness as well.

(I also simplified the code for detecting overrides, because I didn't trust it, even though it turned out to be fine.)

@Skylion007 Updated!

@Skylion007 Updated!

@eellison Fixes a little bug that has to be a quality of life issue for at least some of the people working on inductor...

@pytorchbot rebase

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/rec/156/orig returned non-zero exit code 1

Rebasing (1/1)
Auto-merging tools/linter/adapters/docstring_linter-grandfather.json
CONFLICT (content): Merge conflict in tools/linter/adapters/docstring_linter-grandfather.json
error: could not apply 27e44452222... docstring_linter: Fix #151692 and other issues
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 27e44452222... # docstring_linter: Fix #151692 and other issues

Raised by https://github.com/pytorch/pytorch/actions/runs/16750206703

@eellison : Updated. The actual code change is small: most of the delta is the acceptance tests.