Skip to content

[BE] add type annotations and run mypy on setup.py #156741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

[BE] add type annotations and run mypy on setup.py #156741

wants to merge 19 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jun 24, 2025 •
edited
Loading

@XuehaiPan
Update
c6bc10b 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156741

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 5 Pending, 1 Unrelated Failure

As of commit 10a1fae with merge base c202a73 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 24, 2025
This was referenced Jun 24, 2025
Closed
Closed
Closed
Open
Closed
Closed
Closed
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 24, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
3450d5e 
ghstack-source-id: 6ce9c20
Pull-Request: pytorch#156741
@XuehaiPan XuehaiPan added the module: lint Issues related to our Python/C++ lint rules (run by Travis) label Jun 25, 2025
@XuehaiPan XuehaiPan requested review from Skylion007 and malfet and removed request for Skylion007 June 25, 2025 06:33
@XuehaiPan
Update
952268d 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 25, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
b6f802a 
ghstack-source-id: ab2b77d
Pull-Request: pytorch#156741
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 25, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
e706448 
ghstack-source-id: ab2b77d
Pull-Request: pytorch#156741
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 25, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
9f1bd9f 
ghstack-source-id: ab2b77d
Pull-Request: pytorch#156741
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 25, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
9cdeb84 
ghstack-source-id: ab2b77d
Pull-Request: pytorch#156741
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 25, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
9ace635 
ghstack-source-id: ab2b77d
Pull-Request: pytorch#156741
@XuehaiPan
Update
069a1f8 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 25, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
4ca9af9 
ghstack-source-id: 745164f
Pull-Request: pytorch#156741
@XuehaiPan
Update
e431310 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 25, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
824c795 
ghstack-source-id: e7c0c53
Pull-Request: pytorch#156741
@XuehaiPan
Update
e76241d 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 25, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
faff058 
ghstack-source-id: 050d5e1
Pull-Request: pytorch#156741
@XuehaiPan
Update
8f608db 
[ghstack-poisoned]
@XuehaiPan
Update
de2bc7c 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
db868d1 
ghstack-source-id: 6a3eb15
Pull-Request: pytorch#156741
@XuehaiPan XuehaiPan requested a review from aorenste July 1, 2025 02:31
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
10c8376 
ghstack-source-id: 6a3eb15
Pull-Request: pytorch#156741
@XuehaiPan
Update
62933d3 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
93240ba 
ghstack-source-id: 469a826
Pull-Request: pytorch#156741
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_13t-rocm6_4-build / build

Details for Dev Infra team Raised by workflow job

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
a5fd75a 
ghstack-source-id: 469a826
Pull-Request: pytorch#156741
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
98c7585 
ghstack-source-id: 469a826
Pull-Request: pytorch#156741
@XuehaiPan
Update
10a1fae 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
88c5a0a 
ghstack-source-id: cc61a1a
Pull-Request: pytorch#156741
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add type annotations and run mypy on setup.py
21c66d6 
ghstack-source-id: cc61a1a
Pull-Request: pytorch#156741
@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -f "long s390x ci queue"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@aorenste
Copy link
Contributor

aorenste commented Jul 1, 2025

@XuehaiPan For the future you should probably use "-i" instead of "-f" because it will only ignore the things that are currently pending instead of forcing all future jobs.

pytorchmergebot pushed a commit that referenced this pull request Jul 1, 2025
@XuehaiPan @pytorchmergebot
[BE][Easy][setup] use super().method(...) in command subclasses in …
3df6360 
…`setup.py` (#156044)

Pull Request resolved: #156044
Approved by: https://github.com/albanD
ghstack dependencies: #156741
@github-actions github-actions bot deleted the gh/XuehaiPan/332/head branch August 1, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aorenste aorenste aorenste approved these changes

@malfet malfet Awaiting requested review from malfet

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees
No one assigned
Labels
ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: lint Issues related to our Python/C++ lint rules (run by Travis) open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuehaiPan @pytorchmergebot @aorenste @pytorchbot