[build] remove cmake cache and reconfigure again if it is invalid #156958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156958
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 27845be with merge base 3df6360 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 27, 2025
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 27, 2025
ghstack-source-id: 999ef3c Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 28, 2025
ghstack-source-id: 028cfc0 Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 28, 2025
ghstack-source-id: 98761f3 Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 28, 2025
ghstack-source-id: 6631f29 Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 28, 2025
ghstack-source-id: 6631f29 Pull-Request: pytorch#156958
|
This kind of stuff is why we should switch to scikit-build. |
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: b02628c Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: b02628c Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: b02628c Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: 967655e Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: 967655e Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: 967655e Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 90af777 Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 90af777 Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 90af777 Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 90af777 Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 90af777 Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 90af777 Pull-Request: pytorch#156958
Skylion007
reviewed
Jul 2, 2025
| @@ -2,9 +2,17 @@ | |||
|
|
|||
| import os | |||
| import sys | |||
| import warnings | |||
|
|
|||
|
|
|||
| def which(thefile: str) -> str | None: | |||
There was a problem hiding this comment.
Should we just wrap this with typing_extensions.deprecated?
There was a problem hiding this comment.
I tried this, but typing-extensions is not installed in CI environment because build isolation is disabled.
There was a problem hiding this comment.
Really? It's in the build_requires? sigh...
Skylion007
approved these changes
Jul 2, 2025
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 90af777 Pull-Request: pytorch#156958
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: 90af777 Pull-Request: pytorch#156958
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also:
uv pip install .will create PEP-517 venv twice which breaks build-requires (e.g.,cmake/ninjawith absolute path in first venv) astral-sh/uv#14269Stack from ghstack (oldest at bottom):
setuptools<80.0#156049python setup.py develop/install->[uv ]pip install --no-build-isolation [-e ].#156027pyproject.tomlconsistency #156017setuptools.build_meta:__legacy__->setuptools.build_meta#155998cc @malfet @seemethere