-
Notifications
You must be signed in to change notification settings - Fork 24.9k
[test][do not merge] Upgrade oneDNN to v3.9 #157994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157994
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 6 New Failures, 2 Unrelated FailuresAs of commit 96d0c2e with merge base 3e5e094 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @sanchitintel , I'm trying to upgrade oneDNN to v3.9 for testing. since v3.9 is not officially released, I tried main branch commit first. And it wil fail in
|
Does this fix uxlfoundation/oneDNN#3383 btw? ;-; |
Unfortunately no. We recommend disabling IPO for oneDNN builds on Windows. |
776d19c
to
b40994b
Compare
UT |
Hi @vpirogov , For the bazel build failure of https://github.com/pytorch/pytorch/actions/runs/16334831332/job/46154536338, does |
b40994b
to
210dee3
Compare
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
210dee3
to
d226856
Compare
8211889
to
96d0c2e
Compare
Fix CI failures Fix bazel build failure
Hi @milpuz01 , could you please help verify this CI failure https://github.com/pytorch/pytorch/actions/runs/16643249983/job/47097723925?pr=157994? Thanks! |
Thanks for testing this @yanbing-j. Seems like ACL version should be bumped up to the latest one.
I can test the build with a forked version of this changes after bumping ACL properly to verify. |
@yanbing-j with this commit, the build is working fine. I'll open a draft PR to upgrade ACL with this version. The build is working fine now: https://github.com/pytorch/pytorch/actions/runs/16647200279/job/47110635776 |
Thanks @aditew01 ! Will the PR of upgrading ACL to the version be fast? Maybe I can involve the code change inside the current PR. |
@yanbing-j sounds good to me. Thanks! |
Okay. I have put this into the task list. Thanks! |
cc @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh @jgong5 @mingfeima @sanchitintel @ashokei @jingxu10 @min-jean-cho @Guobing-Chen @Xia-Weiwen @snadampal @malfet @milpuz01 @aditew01 @nikhil-arm @fadara01