Skip to content

[test][do not merge] Upgrade oneDNN to v3.9 #157994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yanbing-j
Copy link
Collaborator

@yanbing-j yanbing-j commented Jul 10, 2025

Copy link

pytorch-bot bot commented Jul 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157994

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 53 Pending

As of commit 1d51259 with merge base bfc873d (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/linux-aarch64 linux aarch64 CI workflow module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration topic: not user facing topic category labels Jul 10, 2025
@yanbing-j yanbing-j added ciflow/trunk Trigger trunk jobs on your pull request ci-no-td Do not run TD on this PR labels Jul 10, 2025
@yanbing-j
Copy link
Collaborator Author

Hi @sanchitintel , I'm trying to upgrade oneDNN to v3.9 for testing. since v3.9 is not officially released, I tried main branch commit first. And it wil fail in test_jit_llga_fuser.py::TestOpCPU::test_add_cpu_float32. Could you please take a look first? Thanks!

FAILED [0.0335s] test_jit_llga_fuser.py::TestOpCPU::test_add_cpu_float32 - AssertionError: Tensor-likes are not close!
2025-07-10T02:59:20.4033167Z 
2025-07-10T02:59:20.4033380Z Mismatched elements: 13696 / 25088 (54.6%)
2025-07-10T02:59:20.4034391Z Greatest absolute difference: 1.701464974517854e+38 at index (0, 0, 5, 12) (up to 1e-05 allowed)
2025-07-10T02:59:20.4035723Z Greatest relative difference: inf at index (0, 4, 25, 12) (up to 1.3e-06 allowed)
2025-07-10T02:59:20.4036446Z 
2025-07-10T02:59:20.4036941Z To execute this test, run the following from the base repo dir:
2025-07-10T02:59:20.4037928Z     python test/test_jit_llga_fuser.py TestOpCPU.test_add_cpu_float32

@Skylion007
Copy link
Collaborator

Does this fix uxlfoundation/oneDNN#3383 btw? ;-;

@vpirogov
Copy link

Does this fix uxlfoundation/oneDNN#3383 btw? ;-;

Unfortunately no. We recommend disabling IPO for oneDNN builds on Windows.

@yanbing-j yanbing-j force-pushed the yanbing/update_onednn_v3.9 branch from 776d19c to b40994b Compare July 17, 2025 02:35
@yanbing-j
Copy link
Collaborator Author

Hi @sanchitintel , I'm trying to upgrade oneDNN to v3.9 for testing. since v3.9 is not officially released, I tried main branch commit first. And it wil fail in test_jit_llga_fuser.py::TestOpCPU::test_add_cpu_float32. Could you please take a look first? Thanks!

FAILED [0.0335s] test_jit_llga_fuser.py::TestOpCPU::test_add_cpu_float32 - AssertionError: Tensor-likes are not close!
2025-07-10T02:59:20.4033167Z 
2025-07-10T02:59:20.4033380Z Mismatched elements: 13696 / 25088 (54.6%)
2025-07-10T02:59:20.4034391Z Greatest absolute difference: 1.701464974517854e+38 at index (0, 0, 5, 12) (up to 1e-05 allowed)
2025-07-10T02:59:20.4035723Z Greatest relative difference: inf at index (0, 4, 25, 12) (up to 1.3e-06 allowed)
2025-07-10T02:59:20.4036446Z 
2025-07-10T02:59:20.4036941Z To execute this test, run the following from the base repo dir:
2025-07-10T02:59:20.4037928Z     python test/test_jit_llga_fuser.py TestOpCPU.test_add_cpu_float32

UT python test/test_jit_llga_fuser.py TestOpCPU.test_add_cpu_float32 has been fixed.

@yanbing-j
Copy link
Collaborator Author

yanbing-j commented Jul 17, 2025

Hi @vpirogov ,

For the bazel build failure of https://github.com/pytorch/pytorch/actions/runs/16334831332/job/46154536338, does #include <altivec.h> need to be inside #ifdef __MMA__ in src/cpu/ppc64/ppc64_gemm_reorder.cpp:20? And I'm not sure if we need to build files under mkl-dnn/src/cpu/ppc64/, can we just simply disable the build of ppc64?

@yanbing-j yanbing-j force-pushed the yanbing/update_onednn_v3.9 branch from b40994b to 210dee3 Compare July 23, 2025 01:26
@yanbing-j
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased yanbing/update_onednn_v3.9 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout yanbing/update_onednn_v3.9 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the yanbing/update_onednn_v3.9 branch from 210dee3 to d226856 Compare July 24, 2025 06:07
@yanbing-j yanbing-j force-pushed the yanbing/update_onednn_v3.9 branch 3 times, most recently from 8211889 to 96d0c2e Compare July 31, 2025 07:53
@yanbing-j yanbing-j added the module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 label Jul 31, 2025
@yanbing-j
Copy link
Collaborator Author

Hi @milpuz01 , could you please help verify this CI failure https://github.com/pytorch/pytorch/actions/runs/16643249983/job/47097723925?pr=157994? Thanks!

@aditew01
Copy link
Collaborator

Hi @milpuz01 , could you please help verify this CI failure https://github.com/pytorch/pytorch/actions/runs/16643249983/job/47097723925?pr=157994? Thanks!

Thanks for testing this @yanbing-j. Seems like ACL version should be bumped up to the latest one.

2025-07-31T07:59:30.9603124Z -- Found ACL: /ComputeLibrary
2025-07-31T07:59:31.0004741Z �[31mCMake Error at third_party/ideep/mkl-dnn/cmake/ACL.cmake:67 (message):
2025-07-31T07:59:31.0005536Z Detected ACL version 25.02, but minimum compatible is 52.0

I can test the build with a forked version of this changes after bumping ACL properly to verify.

@aditew01
Copy link
Collaborator

aditew01 commented Jul 31, 2025

@yanbing-j with this commit, the build is working fine. I'll open a draft PR to upgrade ACL with this version. The build is working fine now: https://github.com/pytorch/pytorch/actions/runs/16647200279/job/47110635776

@yanbing-j
Copy link
Collaborator Author

@yanbing-j with this commit, the build is working fine. I'll open a draft PR to upgrade ACL with this version. The build is working fine now: https://github.com/pytorch/pytorch/actions/runs/16647200279/job/47110635776

Thanks @aditew01 ! Will the PR of upgrading ACL to the version be fast? Maybe I can involve the code change inside the current PR.

@aditew01
Copy link
Collaborator

aditew01 commented Aug 1, 2025

Maybe I can involve the code change inside the current PR.

@yanbing-j sounds good to me. Thanks!

@yanbing-j
Copy link
Collaborator Author

Maybe I can involve the code change inside the current PR.

@yanbing-j sounds good to me. Thanks!

Okay. I have put this into the task list. Thanks!

@yanbing-j yanbing-j added the ciflow/op-benchmark Trigger microbenchmark for operations. label Aug 5, 2025
yanbing-j and others added 2 commits August 12, 2025 08:19
Fix CI failures

Fix bazel build failure
@yanbing-j yanbing-j force-pushed the yanbing/update_onednn_v3.9 branch from 96d0c2e to 1d51259 Compare August 12, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td Do not run TD on this PR ciflow/inductor ciflow/linux-aarch64 linux aarch64 CI workflow ciflow/op-benchmark Trigger microbenchmark for operations. ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration open source topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants