Skip to content

[build] remove wheel from build requirements #158027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[build] remove wheel from build requirements #158027

wants to merge 7 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jul 10, 2025 •
edited
Loading

@XuehaiPan
Update
5e6b575 
[ghstack-poisoned]
@XuehaiPan XuehaiPan requested a review from jeffdaily as a code owner July 10, 2025 14:19
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158027

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 4623427 with merge base 7f14b42 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 10, 2025
This was referenced Jul 10, 2025
Open
Open
Closed
Skylion007
Skylion007 reviewed Jul 10, 2025
View reviewed changes
pyproject.toml
@@ -5,7 +5,6 @@ requires = [
# 70.1.0: min version for integrated bdist_wheel command from wheel package
# 77.0.0: min version for SPDX expression support for project.license
"setuptools>=70.1.0",
"wheel",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure, we don't test with build isolation... I think this might have been an issue with uv, but I forget.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous PR in the stack:

replaces wheel.bdist_wheel.bdist_wheel with setuptools.command.bdist_wheel.bdist_wheel.

@XuehaiPan
Update
571c387 
[ghstack-poisoned]
@XuehaiPan
Update
77633ed 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jul 10, 2025
@XuehaiPan
[build] remove wheel from build requirements
f4ec7aa 
ghstack-source-id: 5545698
Pull-Request: #158027
@XuehaiPan XuehaiPan added module: build Build system issues better-engineering Relatively self-contained tasks for better engineering contributors ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request release notes: releng release notes category release notes: build release notes category topic: build ciflow/inductor labels Jul 10, 2025
@XuehaiPan
Update
b11ab1b 
[ghstack-poisoned]
@XuehaiPan
Update
0bac530 
[ghstack-poisoned]
@XuehaiPan XuehaiPan mentioned this pull request Jul 11, 2025
Open
@XuehaiPan
Update
d9664f6 
[ghstack-poisoned]
@XuehaiPan XuehaiPan mentioned this pull request Jul 11, 2025
Closed
@XuehaiPan XuehaiPan requested a review from Skylion007 July 11, 2025 16:34
Skylion007
Skylion007 reviewed Jul 11, 2025
View reviewed changes
@XuehaiPan
Update
4623427 
[ghstack-poisoned]
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 12, 2025
@XuehaiPan
[build] remove wheel from build requirements
f27e627 
ghstack-source-id: b6f1a88
Pull-Request: pytorch#158027
Skylion007
Skylion007 reviewed Jul 12, 2025
View reviewed changes
requirements.txt
@@ -25,3 +24,4 @@ optree>=0.13.0
psutil
sympy>=1.13.3
typing-extensions>=4.13.2
wheel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it needed here for generic requirements?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a development dependency:

pytorch/.ci/docker/common/install_cpython.sh

Lines 69 to 71 in 9508d73

${prefix}/bin/pip install wheel==0.45.1 setuptools==80.9.0
local abi_tag=$(${prefix}/bin/python -c "from wheel.pep425tags import get_abbr_impl, get_impl_ver, get_abi_tag; print('{0}{1}-{2}'.format(get_abbr_impl(), get_impl_ver(), get_abi_tag()))")
ln -sf ${prefix} /opt/python/${abi_tag}

pytorch/tools/nightly.py

Lines 584 to 608 in 9508d73

@timed("Unpacking wheel file")
def wheel_unpack(
self,
wheel: Path | str,
dest: Path | str,
**popen_kwargs: Any,
) -> subprocess.CompletedProcess[str]:
"""Unpack a wheel into a directory."""
wheel = Path(wheel).absolute()
dest = Path(dest).absolute()
assert wheel.is_file() and wheel.suffix.lower() == ".whl"
return self.wheel("unpack", f"--dest={dest}", str(wheel), **popen_kwargs)
@contextlib.contextmanager
def extracted_wheel(self, wheel: Path | str) -> Generator[Path]:
"""Download and extract a wheel into a temporary directory."""
with tempfile.TemporaryDirectory(prefix="wheel-") as tempdir:
self.wheel_unpack(wheel, tempdir)
subdirs = [p for p in Path(tempdir).absolute().iterdir() if p.is_dir()]
if len(subdirs) != 1:
raise RuntimeError(
f"Expected exactly one directory in {tempdir}, "
f"got {[str(d) for d in subdirs]}."
)
yield subdirs[0]

@github-actions github-actions bot deleted the gh/XuehaiPan/364/head branch August 12, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: build Build system issues open source release notes: build release notes category release notes: releng release notes category topic: build topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuehaiPan @pytorchmergebot @Skylion007 @pytorchbot