Skip to content

[BE][Easy] split build system requirements.txt to a separate file #158111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[BE][Easy] split build system requirements.txt to a separate file #158111

wants to merge 4 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jul 11, 2025 •
edited
Loading

@XuehaiPan
Update
9483f54 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158111

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit ded70cc with merge base 194539e (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Jul 11, 2025
This was referenced Jul 11, 2025
Closed
Closed
Open
Open
Open
@XuehaiPan XuehaiPan added module: build Build system issues module: ci Related to continuous integration ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request topic: build ciflow/inductor module: devx Related to PyTorch contribution experience (HUD, pytorchbot) release notes: devx labels Jul 11, 2025
@XuehaiPan
Copy link
Collaborator Author

XuehaiPan commented Jul 11, 2025 •
edited
Loading

The CI failures are known and unrelated.

@XuehaiPan XuehaiPan requested review from ezyang, huydhn and malfet July 11, 2025 12:12
@XuehaiPan
Update
ce62e2c 
[ghstack-poisoned]
@XuehaiPan XuehaiPan requested a review from a team as a code owner July 12, 2025 11:29
@ezyang
Copy link
Contributor

ezyang commented Jul 12, 2025

Hmm, explain this one more to me? Is this actually the conventional way of doing it? If I am pip installing from source, one way or another I need the build reqs.

@XuehaiPan
Copy link
Collaborator Author

XuehaiPan commented Jul 12, 2025 •
edited
Loading

Hmm, explain this one more to me? Is this actually the conventional way of doing it? If I am pip installing from source, one way or another I need the build reqs.

It is used to simply the installation of build-system requirements in the CI environment. See:

pytorch/pyproject.toml

Line 25 in a0308ed

# FIXME: As of 2025.06.20, it is hard to ensure the minimum version of setuptools in our CI environment.

@ezyang
Copy link
Contributor

ezyang commented Jul 12, 2025

I mean, requirements.txt isn't /only/ used in the CI env https://github.com/pytorch/pytorch#install-dependencies

@XuehaiPan
Copy link
Collaborator Author

I mean, requirements.txt isn't /only/ used in the CI env pytorch/pytorch#install-dependencies

The requirements.txt still includes the split file. There is no change to the requirements.txt.

@XuehaiPan
Update
e598664 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 13, 2025
@XuehaiPan
[BE][Easy] split build system requirements.txt to a separate file
d155e6b 
ghstack-source-id: 6ea0da2
Pull-Request: pytorch#158111
@XuehaiPan
Update
ded70cc 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 15, 2025
@XuehaiPan
[BE][Easy] split build system requirements.txt to a separate file
55ee106 
ghstack-source-id: af180c8
Pull-Request: pytorch#158111
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: Build Official Docker Images / build (12.9, 12.9.1, 9, devel, linux/amd64), Build Official Docker Images / build (12.9, 12.9.1, 9, runtime, linux/amd64)

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable), Build Official Docker Images / build (12.9, 12.9.1, 9, devel, linux/amd64), Build Official Docker Images / build (12.9, 12.9.1, 9, runtime, linux/amd64)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@huydhn huydhn Awaiting requested review from huydhn

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: build Build system issues module: ci Related to continuous integration module: devx Related to PyTorch contribution experience (HUD, pytorchbot) open source release notes: devx release notes: releng release notes category topic: build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuehaiPan @ezyang @pytorchmergebot @pytorchbot